Open
Bug 587425
Opened 14 years ago
Updated 5 months ago
fill_CERTCertificateFields doesn't consistently order its checks of instance/context and nssCryptokiObject_Clone can leave ->label null
Categories
(NSS :: Libraries, defect, P5)
NSS
Libraries
Tracking
(Not tracked)
NEW
People
(Reporter: timeless, Assigned: rrelyea)
Details
(Keywords: coverity, memory-leak, Whiteboard: FIPS)
98 nssCryptokiObject_Clone ( 103 rvObject = nss_ZNEW(NULL, nssCryptokiObject); 104 if (rvObject) { if !object->label, !rvObject->label: 108 if (object->label) { 109 rvObject->label = nssUTF8_Duplicate(object->label, NULL); 112 return rvObject; 632 get_cert_instance(NSSCertificate *c) 641 if (!instance) { 642 instance = nssCryptokiObject_Clone(*ci); 643 } else { 651 instance = nssCryptokiObject_Clone(*ci); 656 return instance; 721 fill_CERTCertificateFields(NSSCertificate *c, CERTCertificate *cc, PRBool forced) 733 instance = get_cert_instance(c); instance can be true: 735 if (instance) { label can be false, see above: 736 stanNick = instance->label; so we don't check context: 737 } else if (context) { stanNick is false: 741 if ((!cc->nickname && stanNick) || forced) { context could be true: 772 if (context) { so we don't do this: 785 } else if (instance) { and we skipped this: 804 nssCryptokiObject_Destroy(instance); by which point we've leaking instance: 822 }
Updated•14 years ago
|
Assignee: nobody → rrelyea
Whiteboard: FIPS
Updated•2 years ago
|
Severity: normal → S3
Updated•5 months ago
|
Severity: S3 → S4
Priority: -- → P5
You need to log in
before you can comment on or make changes to this bug.
Description
•