587497 - invalid json used to generate community map

Status: VERIFIED FIXED

(www.mozilla.org :: General, defect)

Description

[William Duyck [:fuzzyfox]]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-GB; rv:1.9.2.8) Gecko/20100722 Firefox/3.6.8
Build Identifier: 15th August, 2010 @ 9:55pm GMT

invalid json used to generate community map, comma where there should be none

Reproducible: Always

Steps to Reproduce:
just visit http://www.mozilla.org/script/1.0/universe/data.json
Actual Results:  
there is a comma at the end of line 47 when there should be none

Expected Results:  
no comma at the end of line 47

spotted while working on a widget version of the map

Comment 1

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Confirming.

Comment 2

[David Boswell]

Maybe I'm using the JSONLint validator incorrectly, but just removing that comma doesn't make the file valid.  Could you attach a patch of what the valid file should look like with this error fixed?

Comment 3

[William Duyck [:fuzzyfox]]

Attachment: valid data.json

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch by William D

I think you're using JSONLint incorrectly. This is William's file as a patch.

Comment 5

[David Boswell]

The patch in comment #4 is big and covers changes to most of the json file, but the initial comment in the bug mentions just a comma on one line.  Has the scope of this bug changed or are most of the lines marked for change in the patch just formatting changes and not content changes?

Comment 6

[William Duyck [:fuzzyfox]]

the patch actually only incudes the removal of the comma, however jsonlint has a nice way of formatting any json you enter into it, so most, if not all, except the removal of the comma are formatting changes that actually have no effect on the validity.

The patch is just the c&p from json lint after removing the comma.

sorry for the apparent large change :S

Comment 7

[David Boswell]

OK, fix checked in for line 47.  Please verify things are still working (should take a bit to show up live).

http://viewvc.svn.mozilla.org/vc?view=revision&revision=72770

Re comment #4, I was using JSONLint incorrectly.  I realize now I had read the line numbers wrong and had tried removing the comma on the line below this one.

Interestingly, when I had invalid JSON previously the map would stop working in Safari and Chrome (Firefox seemed to handle some JSON errors in the file) but it worked fine in all browsers with this error.

Comment 8

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

JSONLint and Python say this is fixed. William, could you verify?

Comment 9

[William Duyck [:fuzzyfox]]

I can indeed verify. It looks good to me and json lint agrees. How to close a bug? just leave it now marked fixed?

Comment 10

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

I already marked the bug as fixed, but an independent pair of eyes is expected before marking it as verified. Thanks for your help!