587518 - Modify the text "Group your tabs..."

Status: VERIFIED FIXED

(Firefox Graveyard :: Panorama, defect, P2)

Description

[Alex Faaborg [:faaborg] (Firefox UX)]

-In the view menu this shouldn't contain an ellipsis (the action of showing tab groups occurs immediately)

-The command implies first use, instead of access (like "Tab Groups")

-The term "your" makes the command stand out as overly casual compared to all other commands

-The command does not form a sentence with the full menu structure (like "View > Page Source" or "File > Save") because "group" is used as an action

Comment 2

[Raymond Lee [:raymondlee]]

Need to think about the text when in tab view mode as mentioned in bug 587556

Comment 3

[Alex Faaborg [:faaborg] (Firefox UX)]

New string: "Tab Groups" as in "View (the) Tab Groups" like "View (the) Page Source"

We need the change for consistency the structure of all other menu commands.

Comment 4

[Ian Gilman [:iangilman]]

"Group your tabs…" was always meant to be temporary. Now that the feature has an official name, presumably the menu item will simply be "Panorama…".

Comment 5

[Alex Faaborg [:faaborg] (Firefox UX)]

That works fine in terms of the menu structure.  We won't need the ... since the action "viewing the panorama of tabs" occurs immediately.  It's a subtle difference (for instance a command saying switch to tab group would need one, since you have to choose a tab group to carry out the original command).

Comment 6

[Jesse Ruderman]

I think it should be called "View all tabs".  Not everyone uses the feature for grouping.

Comment 7

[Michael Yoshitaka Erlewine [:mitcho]]

(In reply to comment #6)
> I think it should be called "View all tabs".  Not everyone uses the feature for
> grouping.

+1

Comment 8

[Alex Faaborg [:faaborg] (Firefox UX)]

Note that since it is in the view menu, it would then need to be "all tabs".  I'm ok with that, although I think tab groups (even if the user only has one) is better since it helps the user out in the event that they switched groups and are starting to wonder where thier other tabs have gone.

Comment 9

[Ian Gilman [:iangilman]]

I still think it needs to be "Panorama"; we should be consistent about using the feature name. 

Aza?

Comment 10

[Aza Raskin [:aza]]

Our traditional standpoint has not been to use named features in our in-product strings. The reason being that we want something more description (i.e., what this thing does) than whimsical. I can see an argument for "View all tabs" but worry that it doesn't provide enough of an indication of the other actions you can take. Perhaps something like "View and group all tabs..."

CC'ing Mayumi for her input.

Comment 11

[Alex Faaborg [:faaborg] (Firefox UX)]

The top level menu is "view" so then you would need to call the item "and group all tabs..."  These three would work:

All Tabs
Tab Groups
Panorama

also, no ... as the action occurs immediately without requiring additional user input.

Comment 12

[My]

not a fan of "all" since I don't think it adds anything and is not at all personal, so my vote is "View and group your tabs"

Comment 13

[Staś Małolepszy :stas]

(In reply to comment #11)
> The top level menu is "view" so then you would need to call the item "and group
> all tabs..."  These three would work:

This might be so in English, just because "view" allows for some flexibility in interpretation as either verb or noun. In most of the locales, however, "view" is translated into "a view" (the noun).

And even in en-US we seem to take advantage of the ambiguity, as some menu items complete the verb (view -> toolbars, view -> status bar, view -> page source etc), while others don't (view -> stop for instance).

This said, I'd still vote for "Tab Groups". It describes the behavior well and hints at the fact that you can, well, group your tabs. This, in my opinion, increases the discoverability of the feature. It's also short, as opposed to "View and group your tabs" which will likely cause trouble to the localizers. 

I'm not a big fan of "All tabs" as I have a feeling that we use "all" to mean "all tabs from a group in a window" elsewhere. Compare with the behavior of bookmarks -> bookmark all tabs. (It only bookmarks the tabs in the current group.)

Also, I don't think we use possessive pronouns anywhere in the UI, so I'd bar "your" here.

Comment 14

[Mike Beltzner [:beltzner, not reading bugmail]]

Blocking; we should get this right the first time.

Comment 15

[Dão Gottwald [:dao]]

Attachment: patch

This uses "Tab Groups" and keeps "G" as the access key. It also changes the toolbar button's tooltip from "Group Your Tabs" to "Group your tabs".

Comment 16

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/fc8d8dfee20f

Comment 17

[u88484]

Verified fixed

Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b7pre) Gecko/20100918 Firefox/4.0b7pre