Put nsICapturePicker in the properly named xpt, and package it for Firefox

RESOLVED FIXED in mozilla2.0b4

Status

()

Core
Layout: Form Controls
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: philor, Assigned: philor)

Tracking

Trunk
mozilla2.0b4
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

7 years ago
Created attachment 466189 [details] [diff] [review]
create layout_forms.xpt, package it

Since bug 507749 added an IDL file where there wasn't one, and didn't add XPIDL_MODULE to the makefile, rules.mk falls back to MODULE, so nsICapturePicker.idl ends up in layout.xpt, which didn't previously exist and isn't in browser/'s package-manifest, so it doesn't get xpt_link'ed, and we aren't shipping it.
Attachment #466189 - Flags: review?(roc)
(Assignee)

Comment 1

7 years ago
My impression from the dependency-chain is that it isn't really exactly entirely what you would call "working, at all" yet, so not a blocker in that sense, but "there's this file that clearly should be packaged, which is not packaged, wtf?" is one of those things that you really ought not to do to your poor release engineers at 2am, so a nominating in that sense.
blocking2.0: --- → ?
Comment on attachment 466189 [details] [diff] [review]
create layout_forms.xpt, package it

thanks!!!
Attachment #466189 - Flags: review?(roc) → review+
(Assignee)

Updated

7 years ago
Attachment #466189 - Flags: approval2.0?
blocking2.0: ? → ---
Comment on attachment 466189 [details] [diff] [review]
create layout_forms.xpt, package it

Probably worth giving bug 526333 a heads up.
Attachment #466189 - Flags: approval2.0? → approval2.0+
(Assignee)

Comment 4

7 years ago
http://hg.mozilla.org/mozilla-central/rev/db5153579167
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b4
(Assignee)

Updated

7 years ago
Assignee: nobody → philringnalda

Updated

7 years ago
Blocks: 589637
You need to log in before you can comment on or make changes to this bug.