587591 - FormHelper doesnt move focus properly on checkboxes

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Chwiej Pawel]

User-Agent:       Opera/9.80 (Windows NT 5.1; U; pl) Presto/2.6.30 Version/10.60
Build Identifier: Mozilla/5.0 (X11; Linux armv7l; rv:2.0b4pre) Gecko/20100815  Namoroka/4.0b4pre Fennec/2.0a1pre

Maemo 5
Mozilla-central GTK fennec_2.0~a1~20100816005603_armel.deb


Reproducible: Always

Steps to Reproduce:
1. Go to http://mail.google.com/mail/signup (or use the tc)
2. Tap on the first input field (First name) and write something
3. Tap on first checkbox (Stay signed in)
4. Tap on the "next" formhelper button

Actual Results:  
Focus is moved to the second input field (Last name)


Expected Results:  
"Enable Web History" checbox should be focused

Comment 1

[Chwiej Pawel]

Attachment: TC

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Yeah, we're not updating the inner position of the form helper on a user interaction :s

Comment 3

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

The patch check the element on a focus change and if the elements is not the currently focused one and it is handle by the form helper we update the UI to reflect that.

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

http://hg.mozilla.org/mobile-browser/rev/790c8e493009

Comment 5

[Aakash Desai [:aakashd]]

verified FIXED on builds:
Mozilla/5.0 (maemol Linux armv7l; rv:2.0b7pre) Gecko/20101029 Firefox/4.0b8pre Fennec/4.0b2

Mozilla/5.0 (android Linux armv7l; rv:2.0b7pre) Gecko/20101029 Firefox/4.0b8pre Fennec/4.0b2