Closed Bug 587593 Opened 14 years ago Closed 14 years ago

firefox --help displays Usage twice

Categories

(Firefox :: General, defect)

Product:
Firefox
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 4.0b5
Tracking Flags:
Tracking Status
status1.9.2 --- .13-fixed
status1.9.1 --- unaffected

People

(Reporter: glandium, Assigned: glandium)

Details

Attachments

(1 file, 1 obsolete file)

Remove extra usage line in firefox --help output v1.1
858 bytes, patch
glandium
: review+
benjamin
: approval2.0+
dveditz
: approval1.9.2.11-
christian
: approval1.9.2.13+
Details | Diff | Splinter Review 
The firefox --help output looks like this:
Usage: ./firefox-bin [ options ... ] [URL]
       where options include:

X11 options
  --display=DISPLAY  X display to use
  --sync             Make X calls synchronous
  --no-xshm          Don't use X shared memory extension
  --xim-preedit=STYLE
  --xim-status=STYLE
  --g-fatal-warnings Make all warnings fatal

Firefox options
  -h or -help        Print this message.
  -v or -version     Print Firefox version.
  -P <profile>       Start with <profile>.
  -migration         Start with migration wizard.
  -ProfileManager    Start with ProfileManager.
  -no-remote         Open new instance, not a new window in running instance.
  -UILocale <locale> Start with <locale> resources as UI Locale.
  -safe-mode         Disables extensions and themes for this session.
  -jsconsole         Open the Error console.
  -browser           Open a browser window.
  -private           Enable private browsing mode.
  -private-toggle    Toggle private browsing mode.
  -setDefaultBrowser Set this app as the default browser.
Usage: firefox [-flags] [<url>]

The last "Usage:" line is pretty much useless.

Note this also applies to 3.6.
Attachment #466266 - Attachment is patch: true
Attachment #466266 - Attachment mime type: application/octet-stream → text/plain
Attachment #466266 - Flags: review?(gavin.sharp)
Comment on attachment 466266 [details] [diff] [review]
Remove extra usage line in firefox --help output

Please use helpInfo: "", rather than removing it entirely.
Attachment #466266 - Flags: review?(gavin.sharp) → review+
Addressed review comment. Carrying over r+
Assignee: nobody → mh+mozilla
Attachment #466266 - Attachment is obsolete: true
Attachment #466941 - Flags: review+
Attachment #466941 - Flags: approval2.0?
Attachment #466941 - Flags: approval1.9.2.10?
Attachment #466941 - Flags: approval2.0? → approval2.0+
http://hg.mozilla.org/mozilla-central/rev/2c55309634b7
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b5
Comment on attachment 466941 [details] [diff] [review]
Remove extra usage line in firefox --help output v1.1

Approved for 1.9.2.10, a=dveditz for release-drivers
Attachment #466941 - Flags: approval1.9.2.10? → approval1.9.2.10+
Comment on attachment 466941 [details] [diff] [review]
Remove extra usage line in firefox --help output v1.1

missed the 1.9.2.11 release.
Attachment #466941 - Flags: approval1.9.2.11+ → approval1.9.2.11-
Comment on attachment 466941 [details] [diff] [review]
Remove extra usage line in firefox --help output v1.1

Let's try again for next round
Attachment #466941 - Flags: approval1.9.2.12?
Attachment #466941 - Flags: approval1.9.2.12? → approval1.9.2.12+
status1.9.1: --- → unaffected
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: