587593 - firefox --help displays Usage twice

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Mike Hommey [:glandium]]

Attachment: Remove extra usage line in firefox --help output

The firefox --help output looks like this:
Usage: ./firefox-bin [ options ... ] [URL]
       where options include:

X11 options
  --display=DISPLAY  X display to use
  --sync             Make X calls synchronous
  --no-xshm          Don't use X shared memory extension
  --xim-preedit=STYLE
  --xim-status=STYLE
  --g-fatal-warnings Make all warnings fatal

Firefox options
  -h or -help        Print this message.
  -v or -version     Print Firefox version.
  -P <profile>       Start with <profile>.
  -migration         Start with migration wizard.
  -ProfileManager    Start with ProfileManager.
  -no-remote         Open new instance, not a new window in running instance.
  -UILocale <locale> Start with <locale> resources as UI Locale.
  -safe-mode         Disables extensions and themes for this session.
  -jsconsole         Open the Error console.
  -browser           Open a browser window.
  -private           Enable private browsing mode.
  -private-toggle    Toggle private browsing mode.
  -setDefaultBrowser Set this app as the default browser.
Usage: firefox [-flags] [<url>]

The last "Usage:" line is pretty much useless.

Note this also applies to 3.6.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 466266 [details] [diff] [review]
Remove extra usage line in firefox --help output

Please use helpInfo: "", rather than removing it entirely.

Comment 2

[Mike Hommey [:glandium]]

Attachment: Remove extra usage line in firefox --help output v1.1

Addressed review comment. Carrying over r+

Comment 3

[Mike Hommey [:glandium]]

http://hg.mozilla.org/mozilla-central/rev/2c55309634b7

Comment 4

[Daniel Veditz [:dveditz]]

Comment on attachment 466941 [details] [diff] [review]
Remove extra usage line in firefox --help output v1.1

Approved for 1.9.2.10, a=dveditz for release-drivers

Comment 5

[Daniel Veditz [:dveditz]]

Comment on attachment 466941 [details] [diff] [review]
Remove extra usage line in firefox --help output v1.1

missed the 1.9.2.11 release.

Comment 6

[Mike Hommey [:glandium]]

Comment on attachment 466941 [details] [diff] [review]
Remove extra usage line in firefox --help output v1.1

Let's try again for next round

Comment 7

[Mike Hommey [:glandium]]

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/334d3a965836