Closed Bug 587697 Opened 10 years ago Closed 10 years ago

Sharing context menu appears when panning

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(fennec2.0b2+)

Status:
VERIFIED FIXED
Tracking Flags:
Tracking Status
fennec 2.0b2+ ---

People

(Reporter: stechz, Assigned: wesj)

Details

Attachments

(1 file, 1 obsolete file)

Change one line
803 bytes, patch
mfinkle
: review+
Details | Diff | Splinter Review 
When I start panning, and I begin on a link, I often get the "Share Link" menu unintentionally.  I think it'd be best if this timer lived in the chrome side, since the cancel message may not get there as fast as we'd like.

Basically, immediately on link tap we'd send a message with all the data we are right now.  On chrome side, we'd start the timer and if panning starts we cancel the timer right there.
Summary: Long taps often misfire → Sharing context menu appears when panning
tracking-fennec: --- → 2.0b2+
Assignee: nobody → wjohnston
Attached patch Move timer to chrome process (obsolete) — — Splinter Review 
This does what is suggested. I'm having trouble reliably reproducing this right now though, so its tough to test.
Attachment #469598 - Flags: review?(mark.finkle)
Comment on attachment 469598 [details] [diff] [review]
Move timer to chrome process

 
>       case "Browser:MouseDown":
>         this._overlayTimeout.clear();
>-        this._overlayTimeout.clear();
> 
>         let element = elementFromPoint(x, y);

Maybe this was the problem. The removed line should be:

this._contextTimeout.clear();

Stover - how easy can you repro this?
Attached patch Change one line — — Splinter Review 
Well this is a boring patch...
Attachment #469598 - Attachment is obsolete: true
Attachment #470104 - Flags: review?(mark.finkle)
Attachment #469598 - Flags: review?(mark.finkle)
Comment on attachment 470104 [details] [diff] [review]
Change one line

LOL!
Attachment #470104 - Flags: review?(mark.finkle) → review+
pushed:
http://hg.mozilla.org/mobile-browser/rev/b2bdb51a4527
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
verified FIXED on builds: 
Mozilla/5.0 (maemol Linux armv7l; rv:2.0b7pre) Gecko/20101029 Firefox/4.0b8pre Fennec/4.0b2

Mozilla/5.0 (android Linux armv7l; rv:2.0b7pre) Gecko/20101029 Firefox/4.0b8pre Fennec/4.0b2
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.