587800 - Move GetCurrentFrameIndex & GetNumFrames from Image to RasterImage

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[Daniel Holbert [:dholbert]]

FACTS:
 - GetCurrentFrameIndex & GetNumFrames don't make any sense for Vector images
 - These methods are only called by 
     (a) image decoders (which already deal with a RasterImage)
     (b) one place in imgStatusTracker

HENCE:
I propose that we move these methods to RasterImage, and guard them with
     mImage->GetType() & static_cast<RasterImage*>
at the place they're called in imgStatusTracker.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix

Here's a fix.  It layers on top of bholley's deCOM work in bug 587371.  (and I wrote it on top of my patch in bug 587779, but it doesn't depend on that functionality-wise)

For the chunk in imgStatusTracker, we just do the obvious thing for Vector-type images -- send notifications regardless of the fact that we don't have a "number of frames", and use "0" as the frame ID for notifications that require it.

Comment 2

[Daniel Holbert [:dholbert]]

This is a helper for blocker bug 276431 -- hence, requesting blocking.

Comment 3

[Bobby Holley (:bholley)]

Comment on attachment 466432 [details] [diff] [review]
fix

r=bholley

Comment 4

[Daniel Holbert [:dholbert]]

http://hg.mozilla.org/mozilla-central/rev/2d8b7e75baff