58783 - messenger title stays to deleted/moved message

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect, P3)

Description

[(not reading, please use [e-mail] instead)]

go to a folder with 1 message.
select the message
the title of the messenger window gets set to "<subject> - <folder> -
<application name>"
delete the message.
the title doesn't change.

since we don't have a message selected, we aren't re-setting the title.
we should set the title to "<folder> - <application name>" or something.

Comment 1

[(not reading, please use [e-mail] instead)]

taking from putterman.

Comment 2

[[e-mail] (gone - use [e-mail] instead)]

QA->Sheela.

Comment 3

[Sheela Ravindran]

Seth,
was this on a specific build that you saw? Because today's build(2000122606) on
win98 works fine.  If you delete a message from a folder, the next message gets
selected and the title also changes accordingly.

Comment 4

[Henrik Gemal]

Please read the description...:)
A folder with *one* message

With build 20001226 this is still a problem.

Comment 5

[Sheela Ravindran]

got it, thanks.

Comment 6

[Stephan Niemz]

*** Bug 49750 has been marked as a duplicate of this bug. ***

Comment 7

[Jonathon M. Merz]

Probably related to this:  If a message is viewed in the message pane, the
subject is placed in the title bar of the mail window.  Then, if the message
pain is toggled off (via View->Message from the menu bar), the mail window
retains the subject of the message previously being viewed as the window title,
rather than reverting to the standard title.

Comment 8

[Henrik Gemal]

this is also true if you move the last message in a folder to another folder.

Comment 9

[[e-mail] (gone - use [e-mail] instead)]

Attachment: The fix.

Comment 10

[[e-mail] (gone - use [e-mail] instead)]

The fix was to call the setTitleFromFolder function, which does the smart thing
on its own in setting the title of the current window!  Pass it folder and null,
and that function does the rest!  I bet there are lots of dups on this, this was
one of my most-hated bugs!

Comment 11

[[e-mail] (gone - use [e-mail] instead)]

*** Bug 75571 has been marked as a duplicate of this bug. ***

Comment 12

[[e-mail] (gone - use [e-mail] instead)]

By the way, that function is at:
http://lxr.mozilla.org/seamonkey/source/mailnews/base/resources/content/commandglue.js#131

Comment 13

[(not reading, please use [e-mail] instead)]

r=naving privately.

Comment 14

[(not reading, please use [e-mail] instead)]

can you add your fix after all the places we call outlinerSelection.clearSelection()

Comment 15

[[e-mail] (gone - use [e-mail] instead)]

Attachment: New Patch

Comment 16

[(not reading, please use [e-mail] instead)]

we don't dynamically set the title of the search dialog.  so you should not call
setTitleFromFolder().  I'm surprised this didn't give you a js error.

FYI, if that patch was correct you would have missed curly braces {}.

your patch has:

else
  bar;
  foo;

which is really

else
  bar;
foo;

if this was the right fix, you should have had:

else {
  bar;
  foo;
}

Comment 17

[(not reading, please use [e-mail] instead)]

naving is right, setTitleFromFolder() is currently not needed in
ClearThreadPaneSelection()

the reason is this:

ClearThreadPaneSelection() is called by RerootFolder(), which is called by
ChangeFolderByURI().

ChangeFolderByURI() already changes the title.

sr=sspitzer on the original patch,
http://bugzilla.mozilla.org/showattachment.cgi?attach_id=37757

Comment 18

[Asa Dotzler [:asa]]

a= [e-mail] for checkin to the trunk.
(on behalf of drivers)

Comment 19

[[e-mail] (gone - use [e-mail] instead)]

Fix checked in - Checking in msgMail3PaneWindow.js;
/cvsroot/mozilla/mailnews/base/resources/content/msgMail3PaneWindow.js,v  <--  m
sgMail3PaneWindow.js
new revision: 1.146; previous revision: 1.145
done

Comment 20

[[e-mail] (gone - use [e-mail] instead)]

mass accepting my bugs.

Comment 21

[[e-mail] (gone - use [e-mail] instead)]

I messed up, changing from assigned fixed to resolved fixed..sorry for the spam.

Comment 22

[Sheela Ravindran]

Verified this using trunk 2001-08-02-08 build on win98, mac, linux
I tested this using all the delete choices in the server settings for imap and 
pop. (move it to trash, mark it as deleted, remove it immediately)

The only instance where it does not clear the title is when selecting imap 
delete model. After talking to stephen I understand that this patch clears the 
title bar when the message pane is cleared. And we have an existing bug where 
the message pane does not clear. Hence the title bar stays the same. The 
existing bug number for the message pane not cleared when a last message is 
deleted is bug 62938.

Based on my other tests, marking this bug as verified.   The above scenario will 
also work once bug 62938 gets fixed.  

Way to go Stephen!