58786 - No text shown when all panels deleted

Status: RESOLVED FIXED

(SeaMonkey :: Sidebar, defect, P3)

Description

[Mike Pinkerton (not reading bugmail)]

The Delete All Panel Test for sidebar says:

"Expected Results: After step 3, the pane on the right should be blank. After
step 4, no panels should be listed in the Sidebar and a mesage saying " The
Sidebar is currently empty.....and select Sidebar"  should appear"

There is no text in the 10/31/00-14 branch build. All platforms.

Comment 1

[Mike Pinkerton (not reading bugmail)]

hardly a stop-ship, but then again i never know these days.

Comment 2

[Blake Ross]

can't hold for this...

Comment 3

[selmer (gone)]

rtm-, definitely not a stop ship.

Comment 4

[Jason Eager]

Putting on the mozilla 0.9 radar as a "simple fix needed" bug.

Comment 5

[Blake Ross]

bigger things to worry about.

Comment 6

[shrirang khanzode]

spam : changing qa to sujay (New Sidebar QA)

Comment 7

[Samir Gehani]

*** Bug 108207 has been marked as a duplicate of this bug. ***

Comment 8

[sujay]

--> sgehani

Comment 9

[jon rekai]

Attachment: possible fix

This restores the empty sidebar text, and doesn't break the sidebar AFAICT. 
I.e. the test in comment 0 as well as addition/removal/hiding/showing of panels
still works for me.  

Regarding the offending line: |this.node| is "sidebar-panels" when that
statement is hit.

Here's the checkin that introduced that code.  It occurred about a month and
half prior to this PR, but is the most likely candidate for causing this bug.
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&root=/cvsroot&subdir=mozilla/xpfe/components/sidebar/resources&command=DIFF_FRAMESET&file=sidebarOverlay.js&rev2=1.64&rev1=1.63

Comment 10

[Asaf Romano (gone)]

Comment on attachment 155224 [details] [diff] [review]
possible fix

was it checed in?

Comment 11

[timeless]

mozilla/xpfe/components/sidebar/resources/sidebarOverlay.js 	1.123

Comment 12

[jon rekai]

FIXED
thanks!