587861 - Clear D2DWindowSurface upon window destruction

Status: RESOLVED INVALID

(Core :: Widget, defect)

Description

[Bas Schouten (:bas.schouten)]

Attachment: Clear mD2DWindowSurface on ::Destroy

Right now we clear mD2DWindowSurface upon the nsWindow destruction. This means that the VRAM will be released once the garbage collection cycle destroys the action nsWindow object. This means that if I F5 rapidly in a window VRAM usage can go up to 600 MB easily before a GC occurs. By destroying the mD2DWindowSurface upon nsWindow::Destroy we can allocate the VRAM right away improving memory usage.

Comment 1

[Justin Wood (:Callek)]

This broke my local builds...

You should have wrapped this in:

#ifdef CAIRO_HAS_D2D_SURFACE
#endif

like all other uses of mD2DWindowSurface in this file.

Comment 2

[Justin Wood (:Callek)]

Attachment: fix the bustage

This should do it, I won't be able to land within the next few days, so once this has needed flags, if someone can checkin/ridealong this I'd be appreciative

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 467294 [details] [diff] [review]
fix the bustage

I already reviewed a version of this in another bug

Comment 4

[Bas Schouten (:bas.schouten)]

Yeah, I had this patch too on bug 588510.

Comment 5

[Bas Schouten (:bas.schouten)]

This has been superseeded by bug 588690.