587870 - Don't accept log comments with an empty "Email address" field

Status: RESOLVED FIXED

(Tree Management Graveyard :: TBPL, enhancement)

Description

[Phil Ringnalda (:philor)]

I don't care whether people put in a full email address or an irc nick or their own version of "... at ... dot com" spam-proofing, but over and over, if someone stars a build with a completely empty "Email address" field, it's because they are lying about what it is, they know that they are lying about what it is, and they want to hide who it was who lied about it.

Comment 1

[Justin Wood (:Callek)]

I might be able to tackle this, but fwiw at one computer I routinely use, its perma-set to private-browsing-mode, [and I won't change that], so when I go to first-star, I get blank "who", and it surely is not by malice.

Comment 2

[(no longer active)]

(In reply to comment #1)
> I might be able to tackle this, but fwiw at one computer I routinely use, its
> perma-set to private-browsing-mode, [and I won't change that], so when I go to
> first-star, I get blank "who", and it surely is not by malice.

Well, then you should fill that field out every time!  :-)

Comment 3

[Mounir Lamouri (:mounir)]

Attachment: Patch v1

This is fixing the issue with HTML5 Forms (so Firefox >= 4). So, we still can submit the comment with nothing using Firefox 3.6 and some other UA but do we want to make the code more complex just for that?

Note that I didn't change the type to 'email' given that some people might want to specify a wrong email address or an IRC nick as said philor.

Comment 4

[Arpad Borsos [:Swatinem]]

Comment on attachment 504502 [details] [diff] [review]
Patch v1

So this does prevent the submit event to be fired?

Comment 5

[Mounir Lamouri (:mounir)]

(In reply to comment #4)
> Comment on attachment 504502 [details] [diff] [review]
> Patch v1
> 
> So this does prevent the submit event to be fired?

With a browser supporting HTML5 Forms validation like Firefox 4, yes.

Comment 6

[Mounir Lamouri (:mounir)]

Pushed:
https://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/rev/599eee7f0f2a