587872 - Remove include directive from testconfig

Status: VERIFIED FIXED

(Tamarin Graveyard :: Tools, defect)

Description

[Chris Peyer]

Attachment: Remove include directive from acceptance testconfig

The include directive would override any skip directive in testconfig.  This makes it impossible to skip a test on mobile platforms in deep.  Instead of using include, negative-lookahead regular expressions can be used to only run tests in deep phase.

Comment 1

[Chris Peyer]

Note that the test I'm trying to skip in deep is spidermonkey/js1_5/Array/regress-157652.as which was already set to be skipped for arm runs.  However, this skip directive was never followed.

Comment 2

[Brent Baker]

Comment on attachment 466489 [details] [diff] [review]
Remove include directive from acceptance testconfig

What happened to all of the Unicode tests?

Should add a comment about using the negative look-ahead to "include" a test in only a specific config

Comment 3

[Chris Peyer]

Attachment: Build include testlist before starting testrun; set expectedfail for Bug 586397

Decided to leave include in place how it normally works - any include that matches a config will ignore all skips and take precedence.  So it's still not possible to skip a file that has been included for a config except by modifying the include config string.

Added an expectedfail for Bug 586397.  Expectedfail does work w/ the include command.

Modified getTestsList to pare down the list to only included files if the included list is defined.

Comment 4

[Chris Peyer]

Pushed to redux: changeset:   5135:3b98d7dac085