58792 - malloc used instead of nsMemory::Alloc

Status: VERIFIED FIXED

(Core :: XPCOM, defect, P3)

Description

[Jeffrey S. Kobal]

In xpcom/io/nsLocalFileWin.cpp, the Spawn method allocates memory using malloc, 
but later frees it using nsMemory::Free(); all of the other allocations in that 
file use nsMemory::Alloc().

The line:
        my_argv = (char **)malloc(sizeof(char *) * (count + 2) );

Should be:
        my_argv = (char **)nsMemory::Alloc(sizeof(char *) * (count + 2) );

Comment 1

[Ray Whitmer]

Transferring to default XPCOM owner.

Comment 2

[Matthias Versen [:Matti]]

-> reassign to default component owner

Is this already fixed ?

Comment 3

[Doug Turner (:dougt)]

reassign all kandrot xpcom bug.

Comment 4

[Doug Turner (:dougt)]

Checking in nsLocalFileWin.cpp;
/cvsroot/mozilla/xpcom/io/nsLocalFileWin.cpp,v  <--  nsLocalFileWin.cpp
new revision: 1.60; previous revision: 1.59
done

fixed.

Comment 5

[Mike Kaply [:mkaply]]

Code is in - marking verified since Jeff isn't on our team anymore.