587949 - Staging should use production mozconfigs

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P2)

Description

[Rail Aliiev [:rail]]

Attachment: Don't use mozilla2-staging mozconfigs

At the moment we have 2 separate mozconfig directories which should be synced on every change we make to mozconfigs, what is error-prone. It will be better to use the same mozconfigs for both production and staging, but also have a possibility to use custom mozconfigs.

As a possible solution I'd suggest to remove mozconfigs from mozilla2-stage directory. Production and staging will use mozconfigs from mozilla2 directory. If someone needs custom mozconffigs, he/she can clone buildbot-configs repo to stage-ffxbld or personal repo and use it.

Please review the attached patch (which will be tested in staging).

Comment 1

[Chris AtLee [:catlee]]

Comment on attachment 466563 [details] [diff] [review]
Don't use mozilla2-staging mozconfigs

I think this is probably fine.  Ben, what do you think?

Comment 2

[[e-mail] (:bhearsum)]

Comment on attachment 466563 [details] [diff] [review]
Don't use mozilla2-staging mozconfigs

Looks good to me

Comment 3

[Rail Aliiev [:rail]]

Great! I'll test it in staging next week to be sure.

Comment 4

[Rail Aliiev [:rail]]

Attachment: Don't use mozilla2-staging mozconfigs

(In reply to comment #3)
> I'll test it in staging next week to be sure.

Staging run went fine except one thing. config.py GLOBAL_VARS overrides the same variable from localconfg.py, so I had to move config_repo_path to the corresponding files ({production,preproduction,staging}_config.py) to prevent the collision.

Comment 5

[Rail Aliiev [:rail]]

Comment on attachment 468255 [details] [diff] [review]
Don't use mozilla2-staging mozconfigs

http://hg.mozilla.org/build/buildbot-configs/rev/903bb63bdce8