Closed
Bug 587962
Opened 12 years ago
Closed 12 years ago
[JAEGER] JaegerMonkey build and check failed on Solaris x86 with Sun Studio 12
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: leon.sha, Assigned: leon.sha)
Details
Attachments
(3 files, 1 obsolete file)
10.73 KB,
patch
|
dvander
:
review+
|
Details | Diff | Splinter Review |
2.78 KB,
patch
|
dvander
:
review+
|
Details | Diff | Splinter Review |
753 bytes,
patch
|
dvander
:
review+
|
Details | Diff | Splinter Review |
The latest several commits break JaegerMonkey on Solaris x86 with Sun Studio 12. The patch include the following fixes. 1. Disable YARR_CALL for sunstudio. 2. Modify TrampolineSUNWX86.s according the latest changes. 3. Fix a fast call related problem in js_InternalThrow. 4. Fix a build error on sunstudio.
Attachment #466582 -
Attachment is patch: true
Attachment #466582 -
Attachment mime type: application/octet-stream → text/plain
Attachment #466582 -
Flags: review?(dvander)
Comment on attachment 466582 [details] [diff] [review] patch >+ // trampolines.forceReturn added esp by 8 to balance the esp >+ // for fastcall. js_InternalThrow is not a fast call. >+ // We need to skip this add esp instruction using a hack way. >+ forcereturn = (void *)((int32_t)forcereturn + 3); >+#endif Is it possible to change the forceReturn trampoline instead of this hack?
(In reply to comment #1) > Comment on attachment 466582 [details] [diff] [review] > patch > > > >+ // trampolines.forceReturn added esp by 8 to balance the esp > >+ // for fastcall. js_InternalThrow is not a fast call. > >+ // We need to skip this add esp instruction using a hack way. > >+ forcereturn = (void *)((int32_t)forcereturn + 3); > >+#endif > > Is it possible to change the forceReturn trampoline instead of this hack? forceReturn is used by both js_InternalThrow and some fast calls. Another solution is to add a forceReturnFast similar as forceReturn.
This patch didn't do hack things. But there are more changes.
Comment on attachment 466933 [details] [diff] [review] patch v2 Sorry for delay.
Attachment #466933 -
Flags: review?(dvander) → review+
Attachment #466582 -
Attachment is obsolete: true
Attachment #466582 -
Flags: review?(dvander)
http://hg.mozilla.org/projects/jaegermonkey/rev/c2f1e5150e18
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Comment 6•12 years ago
|
||
your code is bustage on windows. http://tinderbox.mozilla.org/showlog.cgi?log=Jaegermonkey/1282292070.1282292335.6899.gz
http://hg.mozilla.org/projects/jaegermonkey/rev/1fe4f48205b7 To fix the bustage.
Since the patch for bug 587833 lunched, we need to modify solaris trampolines too.
Attachment #468264 -
Flags: review?(dvander)
![]() |
||
Updated•12 years ago
|
Attachment #468264 -
Flags: review?(dvander) → review+
Assignee | ||
Comment 10•12 years ago
|
||
Some trap test failed. The code for non-fastcall missing during merge.
Attachment #472520 -
Flags: review?(dvander)
Comment on attachment 472520 [details] [diff] [review] Patch 4 Leon, the JM tree is now for debugging/testing only. The patch that caused this problem hasn't landed on TM yet. I'll make sure to integrate your fix into the final check-in. Thanks!
Attachment #472520 -
Flags: review?(dvander) → review+
Assignee | ||
Comment 12•12 years ago
|
||
http://hg.mozilla.org/projects/jaegermonkey/rev/5492e0774e89
Assignee | ||
Comment 13•12 years ago
|
||
(In reply to comment #11) > Comment on attachment 472520 [details] [diff] [review] > Patch 4 > > Leon, the JM tree is now for debugging/testing only. The patch that caused this > problem hasn't landed on TM yet. > > I'll make sure to integrate your fix into the final check-in. Thanks! Thank you for noticing. I'll also monitor the TM tree.
You need to log in
before you can comment on or make changes to this bug.
Description
•