Wrong text color on folder pane treechildren in selected status with new messages

RESOLVED FIXED in Thunderbird 3.3a1

Status

Thunderbird
Folder and Message Lists
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: Paenglab, Assigned: Paenglab)

Tracking

Trunk
Thunderbird 3.3a1
x86
Windows 7
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

8 years ago
Created attachment 466607 [details] [diff] [review]
Patch

In Bug 581360 I forgot the treechildren in the folder pane when they have new messages and are selected.
In unselected mode the text color is blue and in selected mode white. With this patch the text is left blue, which is better readable.
(Assignee)

Updated

8 years ago
Attachment #466607 - Flags: review?(nisses.mail)
(Assignee)

Updated

8 years ago
Attachment #466607 - Attachment is patch: true
Attachment #466607 - Attachment mime type: application/octet-stream → text/plain
Couldn't get this patch to apply. It tries to add:
+* skin/classic/aero/messenger/folderPane.css (mail/folderPane-aero.css)
to mail/base/jar.mn
But I think that should be /mail/themes/qute/jar.nm
(Assignee)

Comment 2

8 years ago
Created attachment 466665 [details] [diff] [review]
2nd try
Attachment #466607 - Attachment is obsolete: true
Attachment #466665 - Flags: review?(nisses.mail)
Attachment #466607 - Flags: review?(nisses.mail)
Mental note to self tomorrow when I continue reviewing this:
-moz-hyperlinktext instead of -moz-nativehyperlinktext is good, because of https://bugzilla.mozilla.org/show_bug.cgi?id=567603#c32
Comment on attachment 466665 [details] [diff] [review]
2nd try

Had some doubts if it made sense to put the "@media all and (-moz-windows-default-theme)" inside folderPane-aero.css instead of folderPane.css directly (always want to be on the watch for too many files). It turns out it needs to be in -aero, otherwise it will affect the default XP theme too [1], resulting in blue text on blue background. r+

Names and spacing looks correct too.

1. See Luna on - https://developer.mozilla.org/en/CSS/%3A-moz-system-metric%28windows-default-theme%29
Attachment #466665 - Flags: review?(nisses.mail) → review+
Keywords: checkin-needed
Checked in: http://hg.mozilla.org/comm-central/rev/d6124a907621
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.2a1
You need to log in before you can comment on or make changes to this bug.