Closed Bug 588118 Opened 9 years ago Closed 9 years ago

Web Console error messages display the wrong line number

Categories

(DevTools :: General, defect)

x86
All
defect
Not set

Tracking

(blocking2.0 final+)

RESOLVED FIXED
Firefox 4.0b7
Tracking Status
blocking2.0 --- final+

People

(Reporter: dangoor, Assigned: pcwalton)

Details

(Whiteboard: [kd4b6])

Attachments

(1 file)

I just added an error to a file:

14:44:33:643: Exception: foo is not defined Source File: file:///Users/admin/projects/bugzilla/bugreport.html Line: 0, Column: 54 Category: content javascript

The error is on line 54, not column 54.
Attached patch Patch v1Splinter Review
Attachment #468305 - Flags: feedback?(pwalton)
Whiteboard: [kd4b5] → [kd4b6]
Attachment #468305 - Flags: feedback?(pwalton) → feedback+
LGTM, f=me
OS: Mac OS X → All
Attachment #468305 - Flags: review?(sdwilsh)
blatantly lying to users of a debugging tool is a terrible, terrible thing.  This blocks final.
blocking2.0: --- → final+
Comment on attachment 468305 [details] [diff] [review]
Patch v1

>+    var lineColSubs = [aActivityObject.lineNumber,
>+                       aActivityObject.columnNumber];
>     var lineCol = this.getFormatStr("errLineCol", lineColSubs);
Adding a comment here about the correct format would be useful.

r=sdwilsh
Attachment #468305 - Flags: review?(sdwilsh) → review+
Assignee: jviereck → pwalton
http://hg.mozilla.org/mozilla-central/rev/8d82ccccf7dd
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b6
Flags: in-testsuite+
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.