588118 - Web Console error messages display the wrong line number

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[Kevin Dangoor]

I just added an error to a file:

14:44:33:643: Exception: foo is not defined Source File: file:///Users/admin/projects/bugzilla/bugreport.html Line: 0, Column: 54 Category: content javascript

The error is on line 54, not column 54.

Comment 1

[David Dahl :ddahl]

sounds like it is in here: http://mxr.mozilla.org/mozilla-central/source/toolkit/components/console/hudservice/HUDService.jsm?force=1#1161

Comment 2

[Julian Viereck]

Attachment: Patch v1

Comment 3

[Patrick Walton (:pcwalton)]

LGTM, f=me

Comment 4

[Shawn Wilsher :sdwilsh]

blatantly lying to users of a debugging tool is a terrible, terrible thing.  This blocks final.

Comment 5

[Shawn Wilsher :sdwilsh]

Comment on attachment 468305 [details] [diff] [review]
Patch v1

>+    var lineColSubs = [aActivityObject.lineNumber,
>+                       aActivityObject.columnNumber];
>     var lineCol = this.getFormatStr("errLineCol", lineColSubs);
Adding a comment here about the correct format would be useful.

r=sdwilsh

Comment 6

[David Dahl :ddahl]

http://hg.mozilla.org/mozilla-central/rev/8d82ccccf7dd