Closed Bug 588151 Opened 13 years ago Closed 13 years ago

HelperAppDlg doesn't do anything for Nothing

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: mfinkle, Assigned: mfinkle)

Details

Attachments

(1 file)

patch
1.67 KB, patch
mbrubeck
: review+
Details | Diff | Splinter Review 
We never(?) handle the "Nothing" case in HelperAppDlg. We need to cancel the download.
Attached patch patch — — Splinter Review 
Assignee: nobody → mark.finkle

        Attachment #466750 -
        Flags: review?(mbrubeck)

    
    

    
  
Comment on attachment 466750 [details] [diff] [review]
patch

>+          const NS_BINDING_ABORTED = 0x804b0002;

I'd rather see this line at the top of the function (or the file) instead of repeated twice... your call though, if you prefer it this way.

(If you want to refactor this function a little to remove all the code duplication that'd be great too, but I'm not going to demand it.)

        Attachment #466750 -
        Flags: review?(mbrubeck) → review+

    
    

    
  
pushed:
http://hg.mozilla.org/mobile-browser/rev/e2f62fd32fc5
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED

    
  
Status: RESOLVED → VERIFIED

    
    

    
  
Verified on:
Mozilla/5.0(Android; Linux armv7l; rv:2.0b5pre) Gecko/20100820 Namoroka/4.0b5pre Fennec/2.0a1pre

          You need to log in
          before you can comment on or make changes to this bug.