Closed
Bug 588186
Opened 14 years ago
Closed 14 years ago
Remove permanent Debug output (qDebug) from widget related code
Categories
(Core Graveyard :: Widget: Qt, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: romaxa, Assigned: romaxa)
Details
Attachments
(1 file)
9.91 KB,
patch
|
wolfiR
:
review+
|
Details | Diff | Splinter Review |
We have currently a lot of qDebug output in desktop build which is not ifdefed and available on release builds too. I think we should replace it with logging API/NS_WARNINGS/ERRORS/CRITICALS...
Assignee | ||
Comment 1•14 years ago
|
||
Currently I see a lot of qDebug stuff in filepicker and clipboard code.. .we should fix that I think
Assignee | ||
Comment 2•14 years ago
|
||
Comment 3•14 years ago
|
||
Comment on attachment 469468 [details] [diff] [review] Temp fix >- qDebug("No items to drag?"); >+ NS_WARNING("No items to drag?") Please fix the missing semicolon >diff --git a/widget/src/qt/nsFilePicker.cpp b/widget/src/qt/nsFilePicker.cpp >--- a/widget/src/qt/nsFilePicker.cpp >+++ b/widget/src/qt/nsFilePicker.cpp >@@ -243,17 +248,19 @@ nsFilePicker::Show(PRInt16 *aReturn) > QStringList files = mDialog->selectedFiles(); > QString selected; > if (!files.isEmpty()) > { > selected = files[0]; > } > > QString path = QFile::encodeName(selected); >- qDebug("path is '%s'", path.toAscii().data()); >+#ifdef PR_LOGGING >+ PR_LOG(sFilePickerLog, PR_LOG_DEBUG, ("path is '%s'", path.toAscii().data())); >+#endif PR_LOG does not need wrapping into PR_LOGGING. I recommend to remove the #ifdef >@@ -274,17 +281,19 @@ nsFilePicker::Show(PRInt16 *aReturn) > } > > > return NS_OK; > } > > void nsFilePicker::InitNative(nsIWidget *parent, const nsAString &title, PRInt16 mode) > { >- qDebug("nsFilePicker::InitNative()"); >+#ifdef PR_LOGGING >+ PR_LOG(sFilePickerLog, PR_LOG_DEBUG, ("nsFilePicker::InitNative")); >+#endif Same r=me if above nits are fixed
Attachment #469468 -
Flags: review?(mozilla) → review+
Assignee | ||
Comment 4•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/3a69086a2114
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Updated•8 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•