588228 - AssertionError when num_votes is None

Status: VERIFIED FIXED

(support.mozilla.org :: Search, defect)

Description

[Paul Craciunoiu [:paulc]]

Go to:
http://support.mozilla.com/en-US/search?q=&num_voted=2&num_votes=&asked_by=&answered_by=&q_tags=&created=0&created_date=&updated=0&updated_date=&sortby=0&a=1&w=2

Result:
Traceback (most recent call last):

  File "/data/virtualenvs/kitsune/src/django/django/core/handlers/base.py", line 100, in get_response
    response = callback(request, *callback_args, **callback_kwargs)

  File "/data/www/support.mozilla.com/kitsune/apps/search/views.py", line 409, in search
    documents += qc.query(cleaned['q'], filters_q)

  File "/data/www/support.mozilla.com/kitsune/apps/search/clients.py", line 118, in query
    self._prepare_filters(filters)

  File "/data/www/support.mozilla.com/kitsune/apps/search/clients.py", line 84, in _prepare_filters
    f['max'], f.get('exclude', False))

  File "/data/www/support.mozilla.com/kitsune/apps/search/sphinxapi.py", line 387, in SetFilterRange
    assert(isinstance(min_, (int,long)))

AssertionError

Comment 1

[Paul Craciunoiu [:paulc]]

Wouldn't have targeted this for 2.2.3 but I already have a fix for it. Can be pushed out though.

Comment 2

[James Socol [:jsocol, :james]]

Paul: can you take the chance to make sure none of the query string parameters can cause 500 errors?

Comment 3

[Paul Craciunoiu [:paulc]]

Manually looked (read: played with the URL), nothing else seems to cause 500s.

Comment 4

[Paul Craciunoiu [:paulc]]

http://github.com/jsocol/kitsune/commit/6975470794e1d54a22e164e9384734a0d6bfd11a

Comment 5

[Rebecca Billings [:rbillings]]

I still get an error from the original link- should that be working?

Comment 6

[James Socol [:jsocol, :james]]

The original link on production or staging?

Comment 7

[Rebecca Billings [:rbillings]]

Oops, it works in Stage- I forgot to adjust the url. Verified.