If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

AssertionError when num_votes is None

VERIFIED FIXED in 2.2.4

Status

support.mozilla.org
Search
VERIFIED FIXED
7 years ago
7 years ago

People

(Reporter: paulc, Assigned: paulc)

Tracking

unspecified
2.2.4

Firefox Tracking Flags

(Not tracked)

Details

(Assignee)

Description

7 years ago
Go to:
http://support.mozilla.com/en-US/search?q=&num_voted=2&num_votes=&asked_by=&answered_by=&q_tags=&created=0&created_date=&updated=0&updated_date=&sortby=0&a=1&w=2

Result:
Traceback (most recent call last):

  File "/data/virtualenvs/kitsune/src/django/django/core/handlers/base.py", line 100, in get_response
    response = callback(request, *callback_args, **callback_kwargs)

  File "/data/www/support.mozilla.com/kitsune/apps/search/views.py", line 409, in search
    documents += qc.query(cleaned['q'], filters_q)

  File "/data/www/support.mozilla.com/kitsune/apps/search/clients.py", line 118, in query
    self._prepare_filters(filters)

  File "/data/www/support.mozilla.com/kitsune/apps/search/clients.py", line 84, in _prepare_filters
    f['max'], f.get('exclude', False))

  File "/data/www/support.mozilla.com/kitsune/apps/search/sphinxapi.py", line 387, in SetFilterRange
    assert(isinstance(min_, (int,long)))

AssertionError
(Assignee)

Comment 1

7 years ago
Wouldn't have targeted this for 2.2.3 but I already have a fix for it. Can be pushed out though.
Paul: can you take the chance to make sure none of the query string parameters can cause 500 errors?
Target Milestone: 2.2.3 → 2.2.4
(Assignee)

Comment 3

7 years ago
Manually looked (read: played with the URL), nothing else seems to cause 500s.
Target Milestone: 2.2.4 → 2.2.3
(Assignee)

Updated

7 years ago
Target Milestone: 2.2.3 → 2.2.4
(Assignee)

Comment 4

7 years ago
http://github.com/jsocol/kitsune/commit/6975470794e1d54a22e164e9384734a0d6bfd11a
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
I still get an error from the original link- should that be working?
The original link on production or staging?
Oops, it works in Stage- I forgot to adjust the url. Verified.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.