58823 - Crash trying to load games page

Status: VERIFIED FIXED

(Core Graveyard :: Plug-ins, defect, P3)

Description

[shrirang khanzode]

Build: mac branch build 20001031 (limbo1)
SW 8.5 (copied over from 4.x plugins folder) , Flash 5.0 installed


Steps:
1 Go to the above url
2 Click on the 'games' menu at the top
3 Observe that as soon as the page loads, the browser crashes

I am seeing this intermittently, so after step 3 if the browser does not crash 
for you, pls try loading any game and it should crash

This was not happening on 10/30 build.

Comment 1

[shrirang khanzode]

keoword : rtm
stack trace : 
 Call Stack:     (Signature = Shockwave Flash NP-PPC + 0x14b44 (0x1665bae4) 
dc8190be)
     Shockwave Flash NP-PPC + 0x14b44 (0x1665bae4)  
     Shockwave Flash NP-PPC + 0x150bc (0x1665c05c)  
     Shockwave Flash NP-PPC + 0x3cf58 (0x16683ef8)  
     Shockwave Flash NP-PPC + 0xd364 (0x16654304)  
     Shockwave Flash NP-PPC + 0x41bb8 (0x16688b58)  
     ns4xPluginStreamListener::OnStopBinding() [ns4xPluginInstance.cpp, line 
327]
     nsPluginStreamListenerPeer::OnStopRequest() [nsPluginHostImpl.cpp, line 
1298]
     nsHTTPFinalListener::OnStopRequest() [nsHTTPResponseListener.cpp, line 
1158]
     InterceptStreamListener::OnStopRequest() [nsCachedNetData.cpp, line 1206]
     nsHTTPChannel::ResponseCompleted() [nsHTTPChannel.cpp, line 1923]
     nsHTTPServerListener::OnStopRequest() [nsHTTPResponseListener.cpp, line 
729]
     nsOnStopRequestEvent::HandleEvent() [nsAsyncStreamListener.cpp, line 301]
     nsStreamListenerEvent::HandlePLEvent() [nsAsyncStreamListener.cpp, line 97]
     PL_HandleEvent() [plevent.c, line 580]
     PL_ProcessPendingEvents() [plevent.c, line 513]
     nsEventQueueImpl::ProcessPendingEvents() [nsEventQueue.cpp, line 356]
     nsMacNSPREventQueueHandler::ProcessPLEventQueue() [nsToolkit.cpp, line 134]
 

Comment 2

[shrirang khanzode]

reassign:peterl.

Comment 3

[Peter Lubczynski]

It may be possible to fix this crash by applying the patch to bug 54186 to the 
OnStopBinding method as well.

Comment 4

[Peter Lubczynski]

Try increasing the ammount of memory you give Mozilla. Even though the suggested 
size is only 16 Meg (should this be 32 at least), with using values of 50 Meg 
for minimum and prefered, I was not able to crash on any of the games. The 
"update" even worked. Can someone else try this and verify?

Comment 5

[selmer (gone)]

We increased the memory size and we took 54186 on the branch.  Do we really need
to do anything for this bug?  If so, please attach the patch and get reviews in
case there's an opportunity to take this.

Comment 6

[Peter Lubczynski]

I guess from other reports I've recieved, this crash still happens even with
more memory but not all the time. I'm having a hard time reproducing it myself
in the debugger so I'm pulling a fresh tree now. I have an idea of how to fix
this and if it works, I'll post a patch.

Marking [rtm-]

Comment 7

[Peter Lubczynski]

Attachment: patch to fix crash

Comment 8

[Peter Lubczynski]

This patch prevents the call into the plugin if the plugin hasn't been already
initilized.

Comment 9

[av (gone)]

Hm... I am pretty sure I have reviewed this patch some time ago. r=av

Comment 10

[Peter Lubczynski]

patch checked in

Comment 11

[shrirang khanzode]

don't crash anymore with mac trunk build 1212(no matter what I do). VERIFIED 
FIXED.

Comment 12

[Angela Butler]

Adding branch accept in status whiteboard.-->Peter, please check on to the 
branch A.S.A.P.  Thanks.
.Angela...

Comment 13

[Peter Lubczynski]

Patch checked into the BRANCH.