588260 - Control + Shift + ` doesn't switch to the correct group

Status: RESOLVED FIXED

(Firefox Graveyard :: Panorama, defect)

Description

[Raymond Lee [:raymondlee]]

The control + shift +  ` doesn't switch to the correct group. It works as control + '. Furthermore, if there is an orphan tab, it messes up things and no switching through all tabs.

Comment 1

[Raymond Lee [:raymondlee]]

Attachment: v1

Got r+ dolske, f+ ian
https://bugzilla.mozilla.org/show_bug.cgi?id=586719#c6

The orphan tab issue doesn't exist anymore so this patch only fixes the order for switching between groups using the key combination

Comment 2

[Ed Lee :Mardak]

For marking bugs as checkin-needed, it would be good to upload a new patch with the commit message updated with [r=dolske a=..]. Some people will go through bugs with checkin-needed and commit them. I'm not sure how often people are doing that during this beta period, but there's also a landing queue where people can ask for ride-along patches by linking to the bug:

https://wiki.mozilla.org/LandingQueue

Comment 3

[Ed Lee :Mardak]

Oh, and does this patch have approval2.0?

Comment 4

[Raymond Lee [:raymondlee]]

(In reply to comment #3)
> Oh, and does this patch have approval2.0?

Not yet.  Who should we assign approval2.0 to?

Comment 5

[Ed Lee :Mardak]

Comment on attachment 466897 [details] [diff] [review]
v1

You don't request a? from a particular person. But you could poke certain people on irc that you've requested it.

Comment 6

[Dão Gottwald [:dao]]

(In reply to comment #1)
> Got r+ dolske, f+ ian
> https://bugzilla.mozilla.org/show_bug.cgi?id=586719#c6

Dolske said "Please put these changes into a separate bug" and "r+ with that change", which doesn't necessarily mean the he reviewed the groupitems.js changes at all.

Comment 7

[Raymond Lee [:raymondlee]]

(In reply to comment #6)
> (In reply to comment #1)
> > Got r+ dolske, f+ ian
> > https://bugzilla.mozilla.org/show_bug.cgi?id=586719#c6
> 
> Dolske said "Please put these changes into a separate bug" and "r+ with that
> change", which doesn't necessarily mean the he reviewed the groupitems.js
> changes at all.

Oh ok, requested a review.

Comment 8

[Benjamin Smedberg]

Comment on attachment 466897 [details] [diff] [review]
v1

Please do not request approval until reviews are complete.

Comment 9

[Raymond Lee [:raymondlee]]

Attachment: v1 [r=dolske a=dolske]

Comment 10

[Ed Lee :Mardak]

http://hg.mozilla.org/mozilla-central/rev/daf02fa09ca5