588297 - Update the icon for "Firefox is already your default browser"

Status: RESOLVED WORKSFORME

(Firefox :: General, defect)

Description

[Alex Faaborg [:faaborg] (Firefox UX)]

We current display a warning icon for the dialog box "Firefox is already your default browser."  Outside of the larger question of why this dialog box needs to exist, we should update the icon from warning to info.

Comment 1

[Alex Faaborg [:faaborg] (Firefox UX)]

Attachment: Dialog box icons for default browser dialogs

Comment 3

[Christian Ascheberg]

I guess this does not have high priority, but I wanted to look around in the source code (for the first time) and this seemed to be easy. I found this (?):

Code to show dialog box:
http://mxr.mozilla.org/mozilla-central/source/browser/components/preferences/advanced.js#702

calls alert:
http://mxr.mozilla.org/mozilla-central/source/embedding/browser/activex/src/control/PromptService.cpp#698

which has a parameter for the icon in the dialog. That is MB_ICONEXCLAMATION, but MB_ICONINFORMATION already seems to be defined too.

For me it would be interesting to see the fix here.

Comment 4

[Christian Ascheberg]

Attachment: patch

This is mainly quite a bit of copy&paste from alert, but for me it seems to work.

Comment 5

[Justin Dolske [:Dolske]]

I think the better fix, especially now that FF4 is basically out the door, is to get rid of the prompt entirely, and change the pref dialog to reflect this info. I'd sorta rather not add another interface just to use a different icon.

Quick example:

[X] Check to see if Firefox is default browser on startup.
    Firefox is currently your default browser.

[X] Check to see if Firefox is default browser on startup.
    Firefox is not your default browser. [Make default]

Comment 6

[Christian Ascheberg]

(In reply to Justin Dolske [:Dolske] from comment #5)

See bug 317190

Comment 7

[Christian Ascheberg]

The dialog was removed in bug 317190