588318 - error: fail: The contentScriptURL's value is as specified in options.

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[Myk Melez [:myk] [@mykmelez]]

Attachment: patch v1: fixes problem

I see the following test failure on tip on Linux:

error: TEST FAILED: test-content-symbiont.testContentSymbiont (failure)
error: fail: The contentScriptURL's value is as specified in options. ("resource://testpkgs-jetpack-core-data/test-content-symbiont.js" != "resource://jetpack-core-jetpack-core-data/test-content-symbiont.js")
info: Traceback (most recent call last):
  File "resource://testpkgs-jetpack-core-tests/test-content-symbiont.js", line 45, in onLoad
    "The contentScriptURL's value is as specified in options."
  File "resource://testpkgs-jetpack-core-lib/unit-test.js", line 231, in assertEqual
    this.fail(message);
  File "resource://testpkgs-jetpack-core-lib/unit-test.js", line 149, in fail
    console.trace();

It looks like the test compares the value of a property set to self.data.url() to a hardcoded value, but the value has changed.  The test should probably compare the value to the original value to which it was set, since the purpose of the test is to make sure the property correctly reflects that value.

Here's the trivial fix.

Comment 1

[Myk Melez [:myk] [@mykmelez]]

Fixed by changeset https://hg.mozilla.org/labs/jetpack-sdk/rev/4c9c3a424348.

Comment 2

[Myk Melez [:myk] [@mykmelez]]

The Add-on SDK is no longer a Mozilla Labs experiment and has become a big enough project to warrant its own Bugzilla product, so the "Add-on SDK" product has been created for it, and I am moving its bugs to that product.

To filter bugmail related to this change, filter on the word "looptid".