Closed
Bug 588328
Opened 14 years ago
Closed 14 years ago
Look for immediate children of popup notification icon box as anchors
Categories
(Toolkit :: UI Widgets, defect)
Toolkit
UI Widgets
Tracking
()
RESOLVED
FIXED
mozilla2.0b5
People
(Reporter: Mardak, Assigned: Mardak)
References
Details
Attachments
(1 file, 2 obsolete files)
|
3.11 KB,
patch
|
Gavin
:
approval2.0+
|
Details | Diff | Splinter Review |
Upstreaming a fix to better handle complex icons: http://hg.mozilla.org/users/edward.lee_engineering.uiuc.edu/account-central/rev/de43298c0afc#l6.1
|
Assignee | |
Comment 1•14 years ago
|
||
|
||
Comment 2•14 years ago
|
||
Add a test for this to browser_popupNotifications?
|
|
Assignee | |
Comment 3•14 years ago
|
||
Attachment #466961 -
Attachment is obsolete: true
Attachment #466973 -
Flags: review?(gavin.sharp)
Attachment #466961 -
Flags: review?(gavin.sharp)
|
|
||
Comment 4•14 years ago
|
||
Comment on attachment 466973 [details] [diff] [review] v2 >diff --git a/browser/base/content/test/browser_popupNotification.js b/browser/base/content/test/browser_popupNotification.js >+ { // Test #14 >+ run: function() { >+ EventUtils.synthesizeMouse(button, 0, 0, {}); 1,1 ?
Attachment #466973 -
Flags: review?(gavin.sharp) → review+
|
|
Assignee | |
Comment 5•14 years ago
|
||
Account manager uses some complex icons that need this.
Attachment #466973 -
Attachment is obsolete: true
Attachment #468146 -
Flags: approval2.0?
|
|
||
Updated•14 years ago
|
Attachment #468146 -
Flags: approval2.0? → approval2.0+
|
|
Assignee | |
Comment 6•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/1b7a4cadf7d1 Walk up the parent of the click target until we're just inside the icon box.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b5
You need to log in
before you can comment on or make changes to this bug.
Description
•