If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Collection nickname using "+" is not supported

RESOLVED WONTFIX

Status

addons.mozilla.org Graveyard
Collections
RESOLVED WONTFIX
7 years ago
2 years ago

People

(Reporter: dynamis (Tomoya ASAI), Unassigned)

Tracking

Details

(Reporter)

Description

7 years ago
Currently we can set a nickname including "+" (e.g. "webdeveloper+")
When we use "+" in a collection nickname, the link of the url will be like:
https://addons.mozilla.org/ja/firefox/collection/webdeveloper+
# actual collection:
# https://addons.mozilla.org/ja/firefox/collection/85cd6a2e-a555-f5c7-b60d-96d7ca16b404
But it will show collection of
https://addons.mozilla.org/ja/firefox/collection/webdeveloper

another example which use "+" in the middle of the nickname:
https://addons.mozilla.org/ja/firefox/collection/web+developer
In this case, "Collection not found!" will be shown.

 a. We should support "+" character properly
      OR
 b. We should not allow nickname including "+" char
The new system (going live in a couple weeks) will let you manually edit your URL and you can add a + then.

Example:

https://preview.addons.mozilla.org/z/en-US/firefox/collections/clouserw/one+two/
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Pluses are not actually allowed by slugify.  You're able to get one+two because bug 587708 is still open.

Do we want to allow +?
Oh.  I don't feel strongly about it one way or the other.  My gut says not to make special cases unless we need to.  CCing fligtar to see if he cares.
I assumed they weren't allowed because of their special meaning in URL parameters, but don't really care either way.
Alright then, I take back everything I said in comment 1!
Resolution: FIXED → WONTFIX
(Assignee)

Updated

2 years ago
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.