Closed
Bug 588401
Opened 14 years ago
Closed 14 years ago
widget/src/windows compilation causes tons of warnings on mingw
Categories
(Core :: Widget: Win32, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: jacek, Assigned: jacek)
Details
Attachments
(2 files)
|
26.77 KB,
text/plain
|
Details | |
|
24.25 KB,
patch
|
roc
:
review+
joe
:
approval2.0+
|
Details | Diff | Splinter Review |
I've attached a log.
|
Assignee | |
Comment 1•14 years ago
|
||
The attached patch fixes most of the warnings.
Assignee: nobody → jacek
Attachment #467011 -
Flags: review?(roc)
Attachment #467011 -
Flags: review?(roc) → review+
|
|
Assignee | |
Updated•14 years ago
|
Attachment #467011 -
Flags: approval2.0?
|
||
Comment 2•14 years ago
|
||
Comment on attachment 467011 [details] [diff] [review] fix v1.0 I presume this has been pushed to try to make sure it doesn't cause any problems?
Attachment #467011 -
Flags: approval2.0? → approval2.0+
|
|
Assignee | |
Comment 3•14 years ago
|
||
Thanks for the review and approval. I've waited to do try push just before landing as this code changes a lot lately. Passed on try and pushed to m-c: http://hg.mozilla.org/mozilla-central/rev/5fae1fe45a6b
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•