Open Bug 588422 Opened 10 years ago Updated 9 years ago

Use site icons in Data Manager where possible

Categories

(SeaMonkey :: Passwords & Permissions, defect)

defect
Not set

Tracking

(Not tracked)

People

(Reporter: kairo, Unassigned)

References

(Blocks 1 open bug)

Details

Data Manager currently doesn't look as shiny as it could be - esp. icons associated with the listed domains would be a good thing to add.

We'll need to see how well we can map icons from faviconservice to domains instead of individual sites or pages, but there might be ways to get at least some of those icons displayed in the tree for visual identification.
There is some code, and a fragment of a query, which is used to find an icon for keyword autocomplete.

http://mxr.mozilla.org/mozilla-central/ident?i=best_favicon_for_revhost
Blocks: 599097
(In reply to comment #1)
> There is some code, and a fragment of a query, which is used to find an icon
> for keyword autocomplete.
> 
> http://mxr.mozilla.org/mozilla-central/ident?i=best_favicon_for_revhost

Wow, that looks overly complicated, even more so with the usage of temp tables. I had hoped there was some straight forward way to ask the faviconservice for it or so... :(
In addition, this probably will need a different match for the host, as we need to look for any host in the domain, i.e. once we convert the domain to a revhost, we need to look for all revhosts starting with this string, preferably equalling it. I'll need to figure out how to do that, and then get all this into a performant enough state to be queried from a tree view.
BTW, if there was a generic function for doing this, it could also be used for "website" containers in the history view.
mmmulani needed something very similar for his bug 573176 work:

<mmmulani> KaiRo: https://bugzilla.mozilla.org/attachment.cgi?id=470075&action=diff&headers=0#a/browser/components/preferences/siteprefs.js_sec1
<mmmulani> around line 1361 there are some SQL statements, I run through those results with a basic heuristic to pick the favicon
I filed bug 615602 for a generic method to get such an icon.
You need to log in before you can comment on or make changes to this bug.