Closed Bug 588452 Opened 10 years ago Closed 10 years ago

Multitouch: black boxes when zooming and a user can now pan

Categories

(Firefox for Android Graveyard :: Panning/Zooming, defect)

ARM
All
defect
Not set
major

Tracking

(fennec2.0a1+)

VERIFIED FIXED
Tracking Status
fennec 2.0a1+ ---

People

(Reporter: aakashd, Assigned: mbrubeck)

Details

Attachments

(1 file, 1 obsolete file)

Build id:
Mozilla/5.0 (Android; U; Linux armv71; en-US; rv:2.0b4pre) Gecko/20100818 Namoroka/4.0b4pre Fennec/2.0a1pre


Note: this is different from bug 584865. blassey mentions that bug was due to artifacts. This one seems to be some strange factoring 

Steps to Reproduce:
1. Go to addons.mozilla.org
2. Start a multitouch zoom
3. Move the bottom left finger up and down.

Actual Results:
Black boxes pop up in step 2 and the page starts panning in step 3

Expected Results:
Black boxes should not pop up in step 2 and the page should not pan in step 3.
Summary: black boxes on zoom when zooming → Multitouch: black boxes when zooming and a user can now pan
tracking-fennec: --- → ?
tracking-fennec: ? → 2.0b1+
tracking-fennec: 2.0b1+ → 2.0a1+
Assignee: nobody → mbrubeck
Attached patch patch (obsolete) — Splinter Review
If AnimatedZoom.finish() was called before the MozAsyncCanvasRender event was received, then (a) the event handler would fail because this.snapshot would be set to null, and (b) if a new AnimatedZoom object was created in the meantime, then it could render to the canvas while the previous render was still pending.

This patch prevents any use of the snapshot canvas while the MozAsyncCanvasRender event is still pending, and correctly handles the case where finish() is called before handleEvent().
Attachment #467279 - Flags: review?(webapps)
Attached patch patch v2Splinter Review
Fix an exception when this.bv is undefined when finish() is called.
Attachment #467279 - Attachment is obsolete: true
Attachment #467287 - Flags: review?(webapps)
Attachment #467279 - Flags: review?(webapps)
Attachment #467287 - Flags: review?(webapps) → review+
http://hg.mozilla.org/mobile-browser/rev/fa32126e5d30
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
verified FIXED on build:

Mozilla/5.0 (Android; U; Linux armv71; en-US; rv:2.0b4pre) Gecko/20100819 Namoroka/4.0b4pre Fennec/2.0a1pre
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.