Closed Bug 588478 Opened 14 years ago Closed 14 years ago

Escape should not open tab from fan view of stacked tabs

Categories

(Firefox Graveyard :: Panorama, defect)

Product:
Firefox Graveyard
Component:
Panorama
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
Firefox 4.0b5

People

(Reporter: tracy, Assigned: raymondlee)

Details

(Whiteboard: [4b4][in-litmus-bug-week])

Attachments

(1 file, 2 obsolete files)

v1 [r=dolske a=dolske]
1.28 KB, patch
Details | Diff | Splinter Review 
Seen on Firefox4 beta4 (build 2) all platforms

STR:

1) in Tab View, reduce a tab group size until the tabs go into stacked mode
2) open the fan view of the stack by clicking the icon
3) press the escape key

Tested results:
That tab group is opened in the browser. (this is "enter/return" behavior)

Expected:
The fan view dismisses back to stacked, we remain in Tab View
Attached patch v1 (obsolete) — — Splinter Review 

        Attachment #467351 -
        Flags: review?(dolske)

        Attachment #467351 -
        Flags: feedback?(ian)

    
  
Assignee: nobody → raymond

    
    

    
  
Comment on attachment 467351 [details] [diff] [review]
v1

Looks good to me; let's do it. 

Aza, chime in if this UI tweak is not to your liking.

        Attachment #467351 -
        Flags: feedback?(ian) → feedback+

        Attachment #467351 -
        Flags: review?(dolske)

        Attachment #467351 -
        Flags: review+

        Attachment #467351 -
        Flags: approval2.0+

    
    

    
  

      
      
      
      

        Attached patch
          
          
        v1 [r=dolske a=dolske] (obsolete)
        — 
          — Splinter Review
      

    


  

        Attachment #467351 -
        Attachment is obsolete: true

    
  
Keywords: checkin-needed

    
    

    
  
Raymond, you attached the wrong patch here

    
    

    
  


  

        Attachment #468900 -
        Attachment is obsolete: true

    
    

    
  
http://hg.mozilla.org/mozilla-central/rev/88adb1e400a8
Status: NEW → RESOLVED
Closed: 14 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b5

    
    

    
  
verified with Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b5pre) Gecko/20100825 Minefield/4.0b5pre
Status: RESOLVED → VERIFIED

    
    

    
  
Flagging it to pick up during Bug Week (9-13 to 9-17). Just an addition to the stacking test case.
Flags: in-litmus?

    
    

    
  
Added in Litmus:
https://litmus.mozilla.org/show_test.cgi?searchType=by_id&id=12848
Flags: in-litmus? → in-litmus+
Whiteboard: [4b4] → [4b4][in-litmus-bug-week]
Product: Firefox → Firefox Graveyard

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: