588510 - Trunk Build broken for --with-windows-version=600 because of unqualified use of mD2DWindowSurface, GfxInfoConstructor

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Carsten Book [:Tomcat]]

while trying to build windows 7 debug builds for reftests i got a build error:


c:\work\builds\2.0.0\mozilla-central\firefox-debug\dist\include\mozilla/mozalloc
.h(224) : warning C4290: C++ exception specification ignored except to indicate
a function is not __declspec(nothrow)
c:\work\builds\2.0.0\mozilla-central\firefox-debug\dist\include\mozilla/mozalloc
.h(236) : warning C4290: C++ exception specification ignored except to indicate
a function is not __declspec(nothrow)
c:/work/builds/2.0.0/mozilla-central/widget/src/windows/nsWindow.cpp(684) : erro
r C2065: 'mD2DWindowSurface' : undeclared identifier
make[6]: *** [nsWindow.obj] Error 2
make[6]: Leaving directory `/c/work/builds/2.0.0/mozilla-central/firefox-debug/w
idget/src/windows'
make[5]: *** [libs] Error 2
make[5]: Leaving directory `/c/work/builds/2.0.0/mozilla-central/firefox-debug/w
idget/src'
make[4]: *** [libs] Error 2
make[4]: Leaving directory `/c/work/builds/2.0.0/mozilla-central/firefox-debug/w
idget'
make[3]: *** [libs_tier_platform] Error 2
make[3]: Leaving directory `/c/work/builds/2.0.0/mozilla-central/firefox-debug'
make[2]: *** [tier_platform] Error 2
make[2]: Leaving directory `/c/work/builds/2.0.0/mozilla-central/firefox-debug'
make[1]: *** [default] Error 2
make[1]: Leaving directory `/c/work/builds/2.0.0/mozilla-central/firefox-debug'
make: *** [build] Error 2

turned out that removing ac_add_options --with-windows-version=600 result in a success build.

Comment 1

[Carsten Book [:Tomcat]]

note this was with VS 2008 and VS 2010

Comment 2

[Bas Schouten (:bas.schouten)]

How odd that that should undefine CAIRO_HAS_D2D_SURFACE and cause a non-D2D build. That's interesting, we should wrap that call in an #ifdef either way though. Patch coming.

Comment 3

[Bas Schouten (:bas.schouten)]

Attachment: Only clear surface when CAIRO_HAS_D2D_SURFACE is defined

Comment 4

[Bas Schouten (:bas.schouten)]

This has been superseded by bug 588690.

Comment 6

[Nochum Sossonko [:Natch]]

(In reply to comment #2)
> How odd that that should undefine CAIRO_HAS_D2D_SURFACE and cause a non-D2D
> build. That's interesting, we should wrap that call in an #ifdef either way
> though. Patch coming.

Umm, if I understand correctly it is explicitly defined only for Windows 7+ (but I might be reading it wrong):

http://mxr.mozilla.org/mozilla-central/source/configure.in#8360

Comment 7

[Bas Schouten (:bas.schouten)]

(In reply to comment #6)
> (In reply to comment #2)
> > How odd that that should undefine CAIRO_HAS_D2D_SURFACE and cause a non-D2D
> > build. That's interesting, we should wrap that call in an #ifdef either way
> > though. Patch coming.
> 
> Umm, if I understand correctly it is explicitly defined only for Windows 7+
> (but I might be reading it wrong):
> 
> http://mxr.mozilla.org/mozilla-central/source/configure.in#8360
I guess that's probably the first Windows SDK that had the headers.

Comment 8

[Bas Schouten (:bas.schouten)]

Bug 588690 will fix this and is marked blocking. I'll check it in when I have time to wait for the landing queue.

Comment 9

[Nochum Sossonko [:Natch]]

GfxInfoConstructor is also a problem, not sure if it's being addressed as well.

http://mxr.mozilla.org/mozilla-central/source/widget/src/build/nsWinWidgetFactory.cpp#165

Should probably just be placed in the #if MOZ_WINSDK_TARGETVER >= MOZ_NTDDI_WIN7 section right below it.

Comment 10

[Joe Drew (not getting mail)]

I'd take patches to fix this, but this doesn't block.

Comment 11

[Bas Schouten (:bas.schouten)]

Should be fixed with landing of Bug 588690.

Comment 12

[Nochum Sossonko [:Natch]]

(In reply to comment #11)
> Should be fixed with landing of Bug 588690.

GfxInfoConstructor too (comment 9)?

Comment 13

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Why do we have --enable-windows-version=600 any more?  At one point it was added because we didn't have an updated SDK on some machines, but I don't think that's the case any more..