588552 - notifications module should set textClickable argument if onClick handler is given

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[Drew Willcoxon :adw]

Attachment: patch

Someone tweeted [1] that his notification's onClick handler isn't getting called.  He speculates it's because the implementation always sets the textClickable argument of nsIAlertsService.showAlertNotification() to false.  The IDL says this about textClickable:

  If true, causes the alert text to look like a link
  and notifies the listener when user attempts to
  click the alert text.

D'oh.  textClickable's value appears to make no difference on OS X and Growl, but the screenshot provided with the tweet looks like Windows XP, so it might matter there and who knows where else.

This patch sets textClickable to true if an onClick handler is given.

[1] http://twitter.com/asukaze55/status/21211275998
[2] http://mxr.mozilla.org/mozilla-central/source/toolkit/components/alerts/public/nsIAlertsService.idl#52

Comment 1

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 467151 [details] [diff] [review]
patch

r=myk and a0.7=myk for checkin during freeze!

Comment 2

[Drew Willcoxon :adw]

Thanks for the quick review.

http://hg.mozilla.org/labs/jetpack-sdk/rev/24e2df1a66eb

Comment 3

[Myk Melez [:myk] [@mykmelez]]

The Add-on SDK is no longer a Mozilla Labs experiment and has become a big enough project to warrant its own Bugzilla product, so the "Add-on SDK" product has been created for it, and I am moving its bugs to that product.

To filter bugmail related to this change, filter on the word "looptid".