588661 - "loader" option in package.json needs to be prioritized the other way

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[Atul Varma [:atul]]

Currently, if a package declares a "loader" in package.json and depends on another package that also declares a "loader", the dependency wins out--yet it should actually be the case that the main package's loader overrides the dependency.

Comment 1

[Atul Varma [:atul]]

Attachment: patch

Comment 2

[Atul Varma [:atul]]

Attachment: patch with unit test

Comment 3

[Atul Varma [:atul]]

Comment on attachment 467275 [details] [diff] [review]
patch with unit test

Myk, can you review this? I think this is all that's really needed, we don't need to introduce the new functionality in bug 588583.

Comment 4

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 467275 [details] [diff] [review]
patch with unit test

Looks good, works well. r=myk

Comment 5

[Atul Varma [:atul]]

Pushed!

Bug 588661 - "loader" option in package.json needs to be prioritized the other way
Atul Varma [:atul]
http://hg.mozilla.org/labs/jetpack-sdk/rev/c6b37d573a22

Comment 6

[Myk Melez [:myk] [@mykmelez]]

The Add-on SDK is no longer a Mozilla Labs experiment and has become a big enough project to warrant its own Bugzilla product, so the "Add-on SDK" product has been created for it, and I am moving its bugs to that product.

To filter bugmail related to this change, filter on the word "looptid".