Closed Bug 588942 Opened 9 years ago Closed 9 years ago

Error in LoginManagerChild.js : foundLogins is undefined

Categories

(Firefox for Android Graveyard :: General, defect)

x86
Linux
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: vingtetun, Assigned: vingtetun)

Details

Attachments

(1 file)

Attached patch PatchSplinter Review
I see this error sometimes (not sure how to reproduce it) but looking at the code it makes sense that there is an error (foundLogins is undefined sometimes but use to enumerate on it)
Attachment #467542 - Flags: review?(mark.finkle)
Comment on attachment 467542 [details] [diff] [review]
Patch

>diff -r c195d2ca37e3 components/LoginManager.js>

>-                if (!this.countLogins(message.json.formOrigin, "", null))
>-                    return {};
>+                if (!this.countLogins(message.json.formOrigin, "", null)) {
>+                    return {
>+                        foundLogins: {}
>+                    }

 return { foundLogins: {} };
Attachment #467542 - Flags: review?(mark.finkle) → review+
http://hg.mozilla.org/mobile-browser/rev/297ea962a4a2
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Flags: in-testsuite?
Testcase?  any way to test this manually?
You need to log in before you can comment on or make changes to this bug.