588942 - Error in LoginManagerChild.js : foundLogins is undefined

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

I see this error sometimes (not sure how to reproduce it) but looking at the code it makes sense that there is an error (foundLogins is undefined sometimes but use to enumerate on it)

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 467542 [details] [diff] [review]
Patch

>diff -r c195d2ca37e3 components/LoginManager.js>

>-                if (!this.countLogins(message.json.formOrigin, "", null))
>-                    return {};
>+                if (!this.countLogins(message.json.formOrigin, "", null)) {
>+                    return {
>+                        foundLogins: {}
>+                    }

 return { foundLogins: {} };

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

http://hg.mozilla.org/mobile-browser/rev/297ea962a4a2

Comment 3

[Tony Chung [:tchung]]

Testcase?  any way to test this manually?