58898 - Right after a skin change, no alert when going from a secure site to an insecure one

Status: RESOLVED WORKSFORME

(Core Graveyard :: Skinability, defect, P3)

Description

[Boris Zbarsky [:bzbarsky]]

This is branched off from bug 57395 and possibly related to bug 58416.

Steps to reproduce:

1) Make sure the "Alert when leaving a secure site" is on
2) Go to a secure site (like https://www.kozmo.com).
3) Switch skins
4) Go to an insecure site (either following a link or clicking on bookmark or
   typing the url in the urlbar).  In all cases, no alert.  But the lock icon
   changes to unlocked.
5) Hit the back button.
6) Go to an insecure site again (any of the methods in item 3 or hitting the
   forward button).  In this case you get an alert.

Per the comments on bug 57395, it looks like the appropriate listeners get
reattached when we leave the page, but some (or all) of them do not get executed.

Comment 1

[Ben Goodger (use ben at mozilla dot org for email)]

I'm sure this is a duplicate of something we have already. 

Comment 2

[Stephen P. Morse]

Ben, I think the dup you are thinking of is bug 57395 which is referenced in the 
first line of this report.

Also I think the differences between that bug report and this one are that

1. That bug report dealt with the lock icon which is now working properly as 
well as the alert.  This report contends that there is still a problem with the 
alert.

2. That problem dealt with the fact that the problem never cleared up after a 
theme switch.  If I'm interpreting the closing remarks in that report correctly, 
it says that the problem still being reported here eventuall clears up as you 
continue navigating.

That's why this has been deemed a separate bug report.

Comment 3

[Paul Chen]

Pretriage of skinnability bugs, marking nsbeta1-, not going to have time for 
this one during beta1

Comment 4

[Paul Chen]

Marking nsbeta1- bugs as future to get off the radar.

Comment 5

[Paul Chen]

Ok, should get this done for beta1, marking nsbeta1+, mozilla0.9.1, reassigning
to pchen

Comment 6

[Viswanath Ramachandran]

as discussed in team meeting, moving all Nav+ team members nsbeta1+ P3 bugs from 
mozilla0.9.1 to mozilla0.9.2. 

Comment 7

[Vladimir Ermakov]

Attachment: testcase

Comment 8

[Vladimir Ermakov]

sorry abut the attachment, wrong bug!

Comment 9

[Viswanath Ramachandran]

nav triage: moving to m0.9.3 at least. we probably will not support theme 
switching without a restart in the commercial release. 

Comment 10

[Viswanath Ramachandran]

Moving out because Nav team is not going to work on theme switching problems in
the mozilla0.9.3 milestone. We shd do this before mozilla1.0. 

Comment 11

[Paul Chen]

Unless, I don't know something which could very well be, dynamic skin switching
isn't coming before mozilla1.0. Marking future

Comment 12

[Asa Dotzler [:asa]]

->default assignee

Comment 13

[Ben Goodger (use ben at mozilla dot org for email)]

This no longer happens with the current skin switching implementation