588992 - Collection.application issues

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Collections, defect, P2)

Description

[krupa raj[:krupa]]

Attachment: screenshot

steps to reproduce:
1. Load https://preview.addons.mozilla.org/en-US/firefox/collections/ken-saunders100508/tbird/?page=1
2.Notice the add-on count is 36
3.Navigate to page=2 and page 3

observed behavior:
Actual count of add-ons in this collection is 16 in preview.Page=2 has just one add-on whereas page =3 is empty

But add-on count incorrectly shows 36 add-ons

In prod this collection has 37 add-ons.https://addons.mozilla.org/en-US/firefox/collection/tbird?show=15&page=1

Comment 1

[Jeff Balogh (:jbalogh)]

It's a thunderbird collection.  The "hidden" add-ons aren't compatible with Firefox.

fligtar:
* Do we bounce to thunderbird if collection.application=18?
* Do we ever want to filter by app-compatibility on collections?

Comment 2

[Justin Scott [:fligtar]]

(In reply to comment #1)
> * Do we bounce to thunderbird if collection.application=18?

Sure

> * Do we ever want to filter by app-compatibility on collections?

No. App compatibility is only so that if you are browsing the directory in /thunderbird, you only see thunderbird-related collections. But I don't think we should hide anything the creator intentionally puts in a collection.

Comment 3

[Jeff Balogh (:jbalogh)]

http://github.com/jbalogh/zamboni/commit/75c6959


(In reply to comment #2)
> (In reply to comment #1)
> > * Do we bounce to thunderbird if collection.application=18?
> 
> Sure

QA: we're not bouncing.

Comment 4

[krupa raj[:krupa]]

> QA: we're not bouncing.

Fligtar: are you okay with this?

Comment 5

[Justin Scott [:fligtar]]

yes, Jeff and I talked about it

Comment 6

[krupa raj[:krupa]]

I see all the add-ons in https://preview.addons.mozilla.org/en-US/firefox/collections/ken-saunders100508/tbird/?page=1


calling this fixed.