588995 - TBPL is not working for Tracemonkey/JaegerMonkey

Status: VERIFIED FIXED

(Tree Management Graveyard :: TBPL, defect)

Description

[David Mandelin [:dmandelin]]

It never gets past "Loading pushlog..." on the top. It was like this since this morning.

Comment 1

[Robert Helmer [:rhelmer]]

Getting this in the error console for Tracemonkey:

Error: /([^<]+) /.exec(patch.author) is null
Source File: http://tests.themasta.com/tinderboxpushlog/js/PushlogJSONParser.js
Line: 20

Comment 2

[Phil Ringnalda (:philor)]

Try TM after 8:30 tonight, and JM after 11:13 tonight - those thousand-changeset merges are hard on pushlog, and it tends not to manage to finish before tbpl times it out.

Comment 3

[Alon Zakai (:azakai)]

The same problem is happening on TryServer's TBPL now.

Comment 4

[Robert Helmer [:rhelmer]]

I think this is happening because author names don't always have in brackets (most but not all are "User Name <email>", some are just "email"):

$ curl -s 'http://hg.mozilla.org/try/json-pushes?full=1&startdate=12+hours+ago&enddate=now' | grep author | grep -v '<'
    "author": "[e-mail]",

Regression caused by bug 584836?

Comment 5

[Robert Helmer [:rhelmer]]

Attachment: check for < in author name before using regex

Comment 6

[Markus Stange [:mstange]]

Comment on attachment 467606 [details] [diff] [review]
check for < in author name before using regex

We can just tweak the regex to exclude the space. Pushed with that change (and a trim() around it to remove a possible trailing space):
http://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/rev/1fd4bd863cc7

Comment 7

[Robert Helmer [:rhelmer]]

WFM locally using a pushlog JSON feed with missing "<".

Comment 8

[David Mandelin [:dmandelin]]

Thanks very much! This is a key time for the JS team, and I've been really relying on TBPL, so it was great to have a prompt fix.