589005 - Add download path to jetpack-latest.zip to contents of test package

Status: RESOLVED FIXED

(Testing :: General, defect)

Description

[Lukas Blakk [:lsblakk] use ?needinfo]

In order to avoid special-casing the current automation that triggers tests for the upcoming jetpack suite, it would be great if 'make package-tests' could create a dir for jetpack containing the path to downloading the latest jetpack-sdk. This should allow us to start special casing later in the process:

http://hg.mozilla.org/build/buildbotcustom/file/812af5608b6e/process/factory.py#l6281

when we unpack the tests url that was handed in and downloaded for the other test suites as well.

Comment 1

[cmtalbert]

Attachment: Hack to include the jetpack location in m-c for buildbot

As requested by Lukas, I believe this should do the trick.  The build team needs the jetpack download location for the "tip" of jetpack included in the test package.  This way they can reuse all their existing buildbot code.

While on the one hand this is a really stupid hack, on the other, this might be an option to integrate testing into buildbot for harnesses that do not live in the m-c tree.  Like cross-weave and mozmill (we could remove the tons of mozmill code that had to be checked in to m-c precisely because buildbot really can't handle things that aren't in m-c).

Lukas, Myk, let me know if that location is the proper one.

Comment 2

[cmtalbert]

(In reply to comment #1)
> Created attachment 471730 [details] [diff] [review]
> Hack to include the jetpack location in m-c for buildbot
> 
> While on the one hand this is a really stupid hack, on the other, this might be
> an option to integrate testing into buildbot for harnesses that do not live in
> the m-c tree.  Like cross-weave and mozmill (we could remove the tons of
> mozmill code that had to be checked in to m-c precisely because buildbot really
> can't handle things that aren't in m-c).
Oh Damn.  I just realized that for things that have make targets (like mozmill), they still have to be in m-c.  Fortunately jetpack doesn't have a make target in m-c, and doesn't want one.  So this still works for jetpack.

Comment 3

[(not currently active) Ted Mielczarek]

Comment on attachment 471730 [details] [diff] [review]
Hack to include the jetpack location in m-c for buildbot

This is a little weird, but I get that it's easier/better to hardcode it here than on the buildbot sid of things. Can you stick a README or something in testing/jetpack explaining WTF that's there for?

Comment 4

[Lukas Blakk [:lsblakk] use ?needinfo]

Is there a plan to land this soon so I can start running some staging tests?

Comment 5

[cmtalbert]

Attachment: Now with readme file.

A ready to go patch with a readme file.  Carrying forward Ted's review

Comment 6

[cmtalbert]

(In reply to comment #4)
> Is there a plan to land this soon so I can start running some staging tests?

Yes, I'm in the landing queue now.

Comment 7

[cmtalbert]

landed: http://hg.mozilla.org/mozilla-central/rev/6c0c4a7a25b8