589034 - Hera crashes on a new object with slave lag

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Jeff Balogh (:jbalogh)]

Someone forked multidb router to send all queries after a db write to the master.  We might want that.


 File "/data/amo_python/www/preview/zamboni/apps/amo/signals.py", line 9, in flush_front_end_cache
   urls = furls() if hasattr(furls, '__call__') else furls

 File "/data/amo_python/www/preview/zamboni/apps/bandwagon/models.py", line 317, in flush_urls
   '*%s' % self.collection.get_url_path()]

 File "/data/amo_python/www/preview/zamboni/vendor/src/django/django/db/models/fields/related.py", line 300, in __get__
   rel_obj = rel_mgr.using(db).get(**params)

 File "/data/amo_python/www/preview/zamboni/vendor/src/django/django/db/models/query.py", line 341, in get
   % self.model._meta.object_name)

DoesNotExist: Collection matching query does not exist.

Comment 2

[Wil Clouser [:clouserw]]

What's this have to do with hera?

Comment 3

[Jeff Balogh (:jbalogh)]

(In reply to comment #2)
> What's this have to do with hera?

Oh right, it's not actually in hera.  The crash happens in the flush_frontend signal handler.

Comment 4

[Jeff Balogh (:jbalogh)]

This is only happening in CollectionAddon right now.

    def flush_urls(self):
        urls = ['*/addon/%d/' % self.addon_id,
                '*%s' % self.collection.get_url_path()]
        return urls

I don't think we should be flushing add-on pages every time one gets added to a collection.

When we change a collection's add-ons we also .save() the collection to make sure it gets invalidated, so we don't need to flush the collection in here either.

I vote for deleting this flush_urls altogether and waiting to get a real fix (forcing master in flush_urls) if we really need it.

Comment 5

[Jeff Balogh (:jbalogh)]

http://github.com/jbalogh/zamboni/commit/b06ee6e

Comment 6

[krupa raj[:krupa]]

Based on the STR provided in the dupe,I cannot reproduce this traceback anymore.

calling this verified FIXED.