Open Bug 589079 Opened 14 years ago Updated 3 months ago

"Open All in Tabs" replaces existing tab for the first item in bookmark folder (e.g. overwrites the current tab)

Categories

(SeaMonkey :: Tabbed Browser, defect)

defect
Not set
major

Tracking

(Not tracked)

People

(Reporter: doctor__j, Unassigned)

References

Details

(Keywords: dataloss, helpwanted, regression)

Attachments

(1 obsolete file)

User-Agent:       Mozilla/5.0 (Windows NT 5.1; rv:2.0b5pre) Gecko/20100819 SeaMonkey/2.1b1pre
Build Identifier: Mozilla/5.0 (Windows NT 5.1; rv:2.0b5pre) Gecko/20100819 SeaMonkey/2.1b1pre

After landing the new bookmark codes on Seamonkey (Bug 580656), there is a new menu command called "Open All in Tabs" in each bookmark folder.  That command is supposed to open all bookmarks in a bookmark folder in new tabs.  It does so but except the the first bookmark in the bookmark folder.


Reproducible: Always

Steps to Reproduce:
1. Open some tabs in the browser window.
2. Pull down the bookmark menu, select a bookmark folder which contains at least 2 bookmarks and click "Open All in Tabs".
Actual Results:  
The bookmarks in the folder will be opened in new tabs, except for the first bookmark, which will replace the existing tab.

Expected Results:  
All bookmarks in the folder should be opened in new tabs, while keeping the existing tab intact.
That bug was inherited from FF/Toolkit, see Bug 440093. Change component, importance and keywords accordingly.

I support that this must be fixed, especially because I set in the preferences under Browser->Tabbed Browsing: When opening a bookmark group to "Add Tabs". I never expect to lost one tab!
Severity: normal → major
Component: Bookmarks & History → Tabbed Browser
Keywords: dataloss
QA Contact: bookmarks → tabbed-browser
Version: unspecified → Trunk
Middle clicking open all in tabs should open all in new tabs including the first tab.
Bug 440093 now has at long last a simple fix, we should really port this.

Hmm I don't see at first sight in the source code (without debugging) where we do this wrong in the function _openTabset from PlacesUIUtils.jsm or in the called helper functions from utilityOverlay.js, assumed we call the same function for "Open all in Tabs".

Is this regression worth to be added to Bug 467530 (FF2SM)?
Depends on: 440093
Summary: "Open All in Tabs" replaces existing tabs for the first item in bookmark folder → "Open All in Tabs" replaces existing tab for the first item in bookmark folder (e.g. overwrites the current tab)
I have this problem in my SeaMonkey v2.1.10 new installation. Please fix it soon.
Attachment #9383381 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: