589209 - change name of DOM panel to Object

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[Rob Campbell [:rc] (:robcee)]

Currently, the DOM panel's name is confusing. DOM, standing for Document Object Model is the full model of the document contained in a window. When inspecting the currently-misnamed DOM panel shows only the properties of the highlit node. "Object" is a more appropriate term for this view.

Comment 1

[Mihai Sucan [:msucan]]

Attachment: proposed patch

This patch changes the name of the DOM panel to Object panel through-out the Inspector code and UI.

All tests pass, no known regressions.

Additionally, I also fixed bug 588795 with a one-liner.

Comment 2

[Johnathan Nightingale [:johnath]]

Doesn't block, would likely approve a reviewed patch, though.

Comment 3

[Mihai Sucan [:msucan]]

Attachment: smaller patch

This is a smaller patch that the previously proposed one. Here I limit the changes only to the one-liner fix for bug 588795, and to the l10n changes.

Thanks!

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 469084 [details] [diff] [review]
smaller patch

>diff --git a/browser/locales/en-US/chrome/browser/browser.dtd b/browser/locales/en-US/chrome/browser/browser.dtd

>+<!-- LOCALIZATION NOTE (inspectObjectButton.label): This button label
>+  -  appears on the Inspector's toolbar. It is used to open and close the Object
>+  -  panel. There is also a DOM label in inspector.properties for the panel
>+  -  titlebar. -->

Remove "DOM" from the comment, or reference the other string name exactly?

Comment 5

[Mihai Sucan [:msucan]]

(In reply to comment #4)
> Comment on attachment 469084 [details] [diff] [review]
> smaller patch
> 
> >diff --git a/browser/locales/en-US/chrome/browser/browser.dtd b/browser/locales/en-US/chrome/browser/browser.dtd
> 
> >+<!-- LOCALIZATION NOTE (inspectObjectButton.label): This button label
> >+  -  appears on the Inspector's toolbar. It is used to open and close the Object
> >+  -  panel. There is also a DOM label in inspector.properties for the panel
> >+  -  titlebar. -->
> 
> Remove "DOM" from the comment, or reference the other string name exactly?

Thanks for your quick r+ Gavin! Yeah, will update the patch accordingly.

Comment 6

[Mihai Sucan [:msucan]]

Attachment: updated patch

Updated patch as suggested in Gavin's review.

Comment 7

[Mihai Sucan [:msucan]]

Attachment: rebased patch

Rebased patch for mozilla-central.

Comment 8

[David Dahl :ddahl]

http://hg.mozilla.org/mozilla-central/rev/d207cb43a7bf