589232 - Windows l10n nightly builds are failing on central

Status: RESOLVED FIXED

(MailNews Core :: Build Config, defect)

Description

[Vlado Valastiak [:wladow]]

Windows l10n nightly builds are failing on central
The issue is affecting both Shredder and SeaMonkey

http://tinderbox.mozilla.org/showlog.cgi?log=Mozilla-l10n-sk/1282309802.1282311470.14762.gz
http://tinderbox.mozilla.org/showlog.cgi?log=Mozilla-l10n-sk/1282310396.1282313102.22547.gz

cat: ../../mail/installer/windows/app.tag: No such file or directory
make[2]: Leaving directory `/e/buildbot/comm-central-trunk-win32-l10n-full/build/comm-central/mail/locales'
make[1]: Leaving directory `/e/buildbot/comm-central-trunk-win32-l10n-full/build/comm-central/mail/locales'
make[2]: *** [repackage-zip] Error 1
make[1]: *** [repackage-win32-installer] Error 2
make: *** [repackage-win32-installer-sk] Error 2
program finished with exit code 2

cat: ../../suite/installer/windows/app.tag: No such file or directory
make[2]: Leaving directory `/e/builds/slave/comm-central-trunk-win32-l10n-nightly/build/comm-central-trunk/suite/locales'
make[1]: Leaving directory `/e/builds/slave/comm-central-trunk-win32-l10n-nightly/build/comm-central-trunk/suite/locales'
make[2]: *** [repackage-zip] Error 1
make[1]: *** [repackage-win32-installer] Error 2
make: *** [repackage-win32-installer-sk] Error 2
program finished with exit code 2

Comment 1

[Mark Banner (:standard8)]

I believe this is a regression from bug 556644 / bug 586849.

I think I attempted to fix this in my patch for bug 587986, but didn't realise it was current bustage.

My solution there was:

-	              $(topsrcdir)/mail/installer/windows/app.tag"
+	              ../$(topsrcdir)/mail/installer/windows/app.tag"

As I think the packaging process is being run from a different directory.

However, I think a better solution may be to use core_abspath on the location and handle it that way. Other ideas welcome.

I'm not going to get to look further into this until at least Monday. So anyone is welcome to pick this up.

Comment 2

[Robert Kaiser]

../$(topsrcdir) certainly looks strange to me, using an abspath sounds better to me for sure.

Comment 3

[Mark Banner (:standard8)]

Attachment: The fix

This fixes the issue - using core_abspath rather than the other option.

I've tested this by manually following the buildbot steps for a Thunderbird l10n build. Not tested the SeaMonkey one, but the steps should be the same there.

Comment 4

[Robert Kaiser]

Comment on attachment 468649 [details] [diff] [review]
The fix

That looks reasonable. Didn't test myself, but I trust your testing and am pretty sure it works the same for SeaMonkey.

Comment 5

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/comm-central/rev/6c0393a1ba92

Comment 6

[Mark Banner (:standard8)]

The Windows L10n builds are cycling now, and this doesn't seem to have worked.

The error is still the same, so I'm confused, especially as I thought I was testing the same thing.

I'll try grabbing a builder sometime and working this out before deciding what to do next.

Comment 7

[Mark Banner (:standard8)]

I've just gone through this again this patch has fixed the problem - however Thunderbird builders are suffering from a different issue that I didn't pick up on (which meant they were still seeing this issue).

I've just filed bug 590923 for the issue the Thunderbird builders are currently seeing, so we'll hopefully get them going again there, but I will keep an eye on them anyway.

Marking this bug as fixed, as I believe it is actually fixed, but as indicated, there is at least one more bug to follow-up on before these start working again.