58926 - Small patch to nsPluginHostImpl.cpp to allow Qt build

Status: VERIFIED FIXED

(Core Graveyard :: Plug-ins, defect, P3)

Description

[John Griggs]

Attached is a small diff that allows /modules/plugin/nglsrc/nsPluginHostImpl.cpp
to compile cleanly under Qt builds.  All the patch does is add #if
defined(MOZ_WIDGET_GTK) wrappers around the GTK specific bits of code and add
code for the Qt equivalents (wrapped in #if defined(MOZ_WIDGET_QT), of course). 
This change does not affect non-Unix builds at all and is simple enough that it
should be easy to review.  Note that this patch does not purport to add Plugin
support to the Qt port of Mozilla, it just allows the tree to build cleanly
under Qt on machines that do not have GTK installed.

Comment 1

[John Griggs]

Attachment: Patch for modules/plugin/nglsrc/nsPluginHostImpl.cpp for Qt builds

Comment 2

[av (gone)]

Looks fine to me. Eric applied it on his tree and it builds fine. r=pollmann 
a=av

Comment 3

[Brendan Eich [:brendan]]

sr=[e-mail]

Comment 4

[Peter Lubczynski]

Wow, this has been around for a while. Has it been checked in? It was approved.

Comment 5

[av (gone)]

I beleive so. Marking fixed.

Comment 6

[shrirang khanzode]

i believe so too..marking VERIFIED :)