Closed
Bug 589306
Opened 14 years ago
Closed 14 years ago
mozconfig-extra-* files shouldn't be hg ignored.
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: justin.lebar+bug, Assigned: justin.lebar+bug)
Details
Attachments
(1 file)
466 bytes,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
It's currently easy to accidentally push to try without |hg add|ing the mozconfig-extra-* files you've put in your root directory.
Assignee | ||
Comment 1•14 years ago
|
||
Assignee: nobody → justin.lebar+bug
Status: NEW → ASSIGNED
Attachment #467910 -
Flags: review?(ted.mielczarek)
Worth noting why this is the way it is: http://hg.mozilla.org/mozilla-central/rev/9888445d7439
Comment 3•14 years ago
|
||
As long as the .mozconfig* variant stays around, I don't particularly care about no-leading-"." rule being scoped down (i.e., that patch doesn't bother me).
Updated•14 years ago
|
Attachment #467910 -
Flags: review?(ted.mielczarek) → review+
Comment 4•14 years ago
|
||
This is NPOTB, so you can land it without approval.
Assignee | ||
Comment 5•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/f87dcd8ad8e8
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•