589340 - factor out / weaken dummy frames

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Luke Wagner [:luke]]

Attachment: patch

According to Blake, the callee/fun of the dummy frame created in jsdbgapi.cpp is ignored by caps since its a native function.  Therefore, the dummy frames made by jsdbgapi.cpp are doing the same thing as those in jswrapper (providing a scopeChain so that cx->globalObject isn't used) and we can merge the two.  This is good because it puts the grossness into one place, and narrows the set of possibilities of what we can see in a frame, which is good for stack frame evisceration.

Patch passes trace/ref tests, will try-server soon.

Comment 1

[Luke Wagner [:luke]]

Attachment: patch

Green on try.

Comment 2

[Luke Wagner [:luke]]

Attachment: patch

http://hg.mozilla.org/tracemonkey/rev/b6179390c115

Minutes after I land I find that JSCrossCompartmentWrapper::{call,construct} are manually writing to vp[0] and vp[1].  Apparently nothing of value was in the fields of the dummy JSStackFrame being trampled...

Comment 3

[Luke Wagner [:luke]]

http://hg.mozilla.org/tracemonkey/rev/e81fa1f189dc

Comment 4

[Igor Bukanov]

(In reply to comment #3)
> http://hg.mozilla.org/tracemonkey/rev/e81fa1f189dc

That should be http://hg.mozilla.org/tracemonkey/rev/12e0e9006ef4 instead.

Comment 5

[Robert Sayre]

http://hg.mozilla.org/mozilla-central/rev/12e0e9006ef4