Closed Bug 589344 Opened 14 years ago Closed 14 years ago

Add tooltip to utilities button

Categories

(Toolkit :: Add-ons Manager, defect)

defect
Not set
normal

Tracking

()

VERIFIED FIXED
mozilla2.0b5
Tracking Status
blocking2.0 --- beta5+

People

(Reporter: Unfocused, Assigned: ddahl)

References

Details

Attachments

(1 file, 2 obsolete files)

The utilities button has no tooltip. But it needs one!

Wording for Windows: "Options for all add-ons"
Wording for OSX and Linux: "Preferences for all add-ons"
blocking2.0: --- → beta5+
David might as well do this at the same time as bug 589343, unless you've already done something here Blair?
Assignee: bmcbride → ddahl
(In reply to comment #1)
> unless you've already done something here Blair?

I have not. It's all ddahl's now.
Attached patch Patch0 (obsolete) — Splinter Review
not sure if the entities are in the right place in .dtd file
Attachment #469279 - Flags: review?(bmcbride)
Attached patch Patch0 (obsolete) — Splinter Review
Let's hope this is the right one, 3 stringy patches in addons all at once is hard to keep track of and i am ding this on windows. calgon take me away!
Attachment #469279 - Attachment is obsolete: true
Attachment #469286 - Flags: review?(bmcbride)
Attachment #469279 - Flags: review?(bmcbride)
Comment on attachment 469286 [details] [diff] [review]
Patch0

These entities should have the same naming conventions as in bug 589343 - view.utilitiesUnix.tooltip, or something.
Attachment #469286 - Flags: review?(bmcbride) → review-
Attached patch Patch01Splinter Review
Attachment #469286 - Attachment is obsolete: true
Attachment #470107 - Flags: review?(bmcbride)
Attachment #470107 - Flags: review?(bmcbride) → review+
http://hg.mozilla.org/mozilla-central/rev/f8d5ca6e16d9
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b5
If my assumption about the Utilities button being the one with the cogwheel is correct, I don't think this button should actually be called options or preferences. It's popup menu only has one preference and three action items. May I suggest to come up with better naming for it?
Verified fixed
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b5pre) Gecko/20100827 Firefox/4.0b5pre
Status: RESOLVED → VERIFIED
Do we have or want an automated test for? Or is a manual test necessary?
Flags: in-testsuite?
Flags: in-litmus?
(In reply to comment #11)
> Do we have or want an automated test for? Or is a manual test necessary?

Its only a tooltip - no test needed, IMO.


(In reply to comment #9)
> If my assumption about the Utilities button being the one with the cogwheel is
> correct, I don't think this button should actually be called options or
> preferences. It's popup menu only has one preference and three action items.
> May I suggest to come up with better naming for it?

Believe it or not, we did actually spend a decent amount of time trying to figure out the wording for this. Unfortunately, there's no good standard wording for a list of miscellaneous items (although "tools" is sometimes used, it isn't very effective). "Preferences" is at least somewhat consistent with other usage in Toolkit and Firefox (and "Options" for Windows, since that's what is used there).

Open to suggestions though - but such a wording change needs to be done before Beta 6 (before 10th September). That's best done in a new bug, I think.
Flags: in-testsuite?
Flags: in-testsuite-
Flags: in-litmus?
Flags: in-litmus-
(In reply to comment #12)
> Open to suggestions though - but such a wording change needs to be done before
> Beta 6 (before 10th September). That's best done in a new bug, I think.

OK, I filed bug 591876.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: