589360 - remove target OS line from Mac OS X mozconfig files for mozilla-2.0

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Josh Aas]

Attachment: fix v1.0

We added mozconfig lines for Mac OS X target OS in bug 586832, now fixing bug 583318 has done away with the need for that. We should take the lines out from the mozconfigs.

Comment 1

[Nick Thomas [:nthomas] (UTC+12)]

What happens to branches which haven't merged from m-c since the landing there on the 20th ? Do we cause bustage and require clobbers ?

If the mozconfig line is a no-op now I'm happy to leave the mozconfigs alone until everyone merges, avoiding the productivity loss from a clobbers.

Comment 2

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 467975 [details] [diff] [review]
fix v1.0

Patch looks fine, please hold off landing it per comment #1

Comment 3

[Josh Aas]

Reassigning to nthomas for landing whenever we're ready.

Comment 4

[Nick Thomas [:nthomas] (UTC+12)]

At this point everything except places has merged http://hg.mozilla.org/mozilla-central/rev/9f193e1683ee. I'm tempted to land the mozconfig change and places can live with targetting the wrong OS until they merge.

Comment 5

[Shawn Wilsher :sdwilsh]

(In reply to comment #4)
> At this point everything except places has merged
> http://hg.mozilla.org/mozilla-central/rev/9f193e1683ee. I'm tempted to land the
> mozconfig change and places can live with targetting the wrong OS until they
> merge.
I cam merge when I get in today.

Comment 6

[Shawn Wilsher :sdwilsh]

(In reply to comment #4)
> At this point everything except places has merged
> http://hg.mozilla.org/mozilla-central/rev/9f193e1683ee. I'm tempted to land the
> mozconfig change and places can live with targetting the wrong OS until they
> merge.
Just pushed the merge now.

Comment 7

[Nick Thomas [:nthomas] (UTC+12)]

Thanks Shawn! I'll land the mozconfigs later today (or maybe Sunday) when the reconfigure will hurt less.

Comment 8

[Nick Thomas [:nthomas] (UTC+12)]

As landed:
  http://hg.mozilla.org/build/buildbot-configs/rev/783a57c3d1d0