Closed Bug 589360 Opened 14 years ago Closed 14 years ago

remove target OS line from Mac OS X mozconfig files for mozilla-2.0

Categories

(Release Engineering :: General, defect)

x86_64
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jaas, Assigned: nthomas)

Details

Attachments

(1 file)

Attached patch fix v1.0Splinter Review
We added mozconfig lines for Mac OS X target OS in bug 586832, now fixing bug 583318 has done away with the need for that. We should take the lines out from the mozconfigs.
Attachment #467975 - Attachment is patch: true
Attachment #467975 - Attachment mime type: application/octet-stream → text/plain
Attachment #467975 - Flags: review?(nrthomas)
Assignee: nobody → joshmoz
What happens to branches which haven't merged from m-c since the landing there on the 20th ? Do we cause bustage and require clobbers ?

If the mozconfig line is a no-op now I'm happy to leave the mozconfigs alone until everyone merges, avoiding the productivity loss from a clobbers.
Comment on attachment 467975 [details] [diff] [review]
fix v1.0

Patch looks fine, please hold off landing it per comment #1
Attachment #467975 - Flags: review?(nrthomas) → review+
Reassigning to nthomas for landing whenever we're ready.
Assignee: joshmoz → nrthomas
At this point everything except places has merged http://hg.mozilla.org/mozilla-central/rev/9f193e1683ee. I'm tempted to land the mozconfig change and places can live with targetting the wrong OS until they merge.
(In reply to comment #4)
> At this point everything except places has merged
> http://hg.mozilla.org/mozilla-central/rev/9f193e1683ee. I'm tempted to land the
> mozconfig change and places can live with targetting the wrong OS until they
> merge.
I cam merge when I get in today.
(In reply to comment #4)
> At this point everything except places has merged
> http://hg.mozilla.org/mozilla-central/rev/9f193e1683ee. I'm tempted to land the
> mozconfig change and places can live with targetting the wrong OS until they
> merge.
Just pushed the merge now.
Thanks Shawn! I'll land the mozconfigs later today (or maybe Sunday) when the reconfigure will hurt less.
As landed:
  http://hg.mozilla.org/build/buildbot-configs/rev/783a57c3d1d0
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: