589364 - Change weekly downloads to active users

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect, P1)

Description

[Justin Scott [:fligtar]]

We currently show weekly downloads in most add-on listing pages across the site. Let's switch to showing the average daily users from the past 7 days.

This should appear as "123,456 users".

Comment 1

[Jeff Balogh (:jbalogh)]

HOW AM I SUPPOSED TO KNOW THAT THIS IS AVERAGE DAILY USERS? </krupa>

Comment 2

[Wil Clouser [:clouserw]]

This is a new calculation.  If Redis stays alive with the 5.11.8 push, we'll use that for this.

Comment 4

[Justin Scott [:fligtar]]

This change should not apply to things that don't have user counts. Search providers are all that comes to mind, and they should stay as weekly downloads.

We should also add a new "Users" sort to browse pages.

Comment 5

[Jeff Balogh (:jbalogh)]

(In reply to comment #4)
> We should also add a new "Users" sort to browse pages.

We have sort=popular right now so that the real sort column is abstracted.  The browse pages won't need frontend changes.

Comment 6

[Justin Scott [:fligtar]]

Popular is only used on the homepage. Actual browse pages use "Downloads", which should be kept.

Comment 7

[Jeff Balogh (:jbalogh)]

(In reply to comment #6)
> Popular is only used on the homepage. Actual browse pages use "Downloads",
> which should be kept.

Ah, the tab says Downloads but the query param is popular.

How many tabs is too many?

Comment 8

[krupa raj[:krupa]]

I agree with Jeff here. The only reason people would sort by "Popular" is to see how many people use a particular add-on. Since "active users" is a more accurate measure of that criteria,providing "Total Downloads" info to regular users is not very useful.

Comment 9

[Wil Clouser [:clouserw]]

Fligtar: can you summarize what needs to happen here?

Comment 10

[Justin Scott [:fligtar]]

Sure thing!

Listing pages should replace "weekly downloads" with the average active daily user count over the past 7 days. This should be displayed as "123,456 users".

As search providers don't have user counts, we'll continue displaying weekly downloads there.

We should add a new "Users" sort tab to browse pages, and the Popularity tab on the homepage should sort by users instead of downloads.

Comment 11

[Dave Garrett]

(In reply to comment #10)
> We should add a new "Users" sort tab to browse pages, and the Popularity tab on
> the homepage should sort by users instead of downloads.

Does that mean that we'll have both a sort by downloads and a sort by users mode here?: https://addons.mozilla.org/en-US/firefox/search/?q=test

so, it'll have: Keyword Match, Newest, Updated, Rating, Downloads, Users
(with the currently existing "downloads" renamed from "popularity")

and for here: https://addons.mozilla.org/en-US/firefox/extensions/

it it'll have: Name, Updated, Created, Downloads, Users, Rating

Correct? (though, the placement of "Rating" should be rearranged to be consistent as it currently is not; there's also no "Created" in search but there is in browse, which is odd)

Comment 12

[Justin Scott [:fligtar]]

Why the large TM bump for a P3?

Comment 13

[Wil Clouser [:clouserw]]

It's not on the goal list.  I thought we could fit it in, but it got complicated so I kicked it out.

Comment 14

[Justin Scott [:fligtar]]

This is blocking the new homepage/details designs.

Comment 15

[Wil Clouser [:clouserw]]

-> jbalogh for backend impala work

Comment 16

[Jeff Balogh (:jbalogh)]

https://github.com/jbalogh/zamboni/commit/5c74c9b

Comment 17

[Justin Scott [:fligtar]]

This number is only for the last 7 days, right? I think it used to be for the whole add-on's life.

Comment 18

[Jeff Balogh (:jbalogh)]

(In reply to comment #17)
> This number is only for the last 7 days, right? I think it used to be for
> the whole add-on's life.

It will be once the cron runs tonight.

Comment 19

[krupa raj[:krupa]]

> Listing pages should replace "weekly downloads" with the average active
> daily user count over the past 7 days. This should be displayed as "123,456
> users".


/featured and /creatured pages do not list the active daily users count.

Comment 20

[Jeff Balogh (:jbalogh)]

(In reply to comment #19)
> > Listing pages should replace "weekly downloads" with the average active
> > daily user count over the past 7 days. This should be displayed as "123,456
> > users".
> 
> 
> /featured 

Yes it does.

> and /creatured pages do not list the active daily users count.

That was not requested.

Comment 21

[krupa raj[:krupa]]

Filed bug 663127 and bug 662993

verified at 
https://addons-next.allizom.org/en-us/firefox/featured
https://addons-next.allizom.org/en-US/firefox/collections/mozilla/webdeveloper/
https://addons-next.allizom.org/en-us/firefox/user/346/
https://addons-next.allizom.org/en-US/firefox/search/?q=test&cat=all&x=0&y=0

Comment 22

[Dave Garrett]

(In reply to comment #18)
> (In reply to comment #17)
> > This number is only for the last 7 days, right? I think it used to be for
> > the whole add-on's life.
> 
> It will be once the cron runs tonight.

It's showing with the lifetime average -> filed bug 663261

Comment 23

[Justin Scott [:fligtar]]

(In reply to comment #4)
> This change should not apply to things that don't have user counts. Search
> providers are all that comes to mind, and they should stay as weekly
> downloads.

(In reply to comment #10)
> As search providers don't have user counts, we'll continue displaying weekly
> downloads there.

This wasn't done and search provider popularity sorting is broken. https://addons.mozilla.org/en-US/firefox/search-tools/business

Comment 24

[Jeff Balogh (:jbalogh)]

Why do some of these show users? https://addons.mozilla.org/en-US/firefox/search-tools/?sort=users

Comment 25

[krupa raj[:krupa]]

(In reply to comment #24)
> Why do some of these show users?
> https://addons.mozilla.org/en-US/firefox/search-tools/?sort=users

Search extensions(.xpi) have users but not the search providers(.xml). 

Justin, is that correct?

Comment 26

[Justin Scott [:fligtar]]

Yes

Comment 27

[Jeff Balogh (:jbalogh)]

(In reply to comment #25)
> (In reply to comment #24)
> > Why do some of these show users?
> > https://addons.mozilla.org/en-US/firefox/search-tools/?sort=users
> 
> Search extensions(.xpi) have users but not the search providers(.xml). 

https://addons.mozilla.org/en-US/firefox/addon/marriott-hotel-search-by-keywo/

3,505 users

https://addons.mozilla.org/firefox/downloads/latest/9100/addon-9100-latest.xml

Comment 28

[Justin Scott [:fligtar]]

Search providers don't have GUIDs and don't check AMO for updates; it is impossible for us to know their active users. The 15 that have them are due to some bug.

mysql> select average_daily_users, count(*) from addons where addontype_id=4 group by average_daily_users;
+---------------------+----------+
| average_daily_users | count(*) |
+---------------------+----------+
|                   0 |     4632 | 
|                   1 |        1 | 
|                  57 |        1 | 
|                 193 |        1 | 
|                 510 |        1 | 
|                1795 |        1 | 
|                1936 |        1 | 
|                2101 |        1 | 
|                2627 |        1 | 
|                2714 |        1 | 
|                2891 |        1 | 
|                2979 |        1 | 
|                3220 |        1 | 
|                3341 |        1 | 
|                3505 |        1 | 
|                5976 |        1 | 
+---------------------+----------+
16 rows in set (0.14 sec)

Comment 29

[Jeff Balogh (:jbalogh)]

https://github.com/jbalogh/zamboni/commit/d40ca1d

Comment 30

[krupa raj[:krupa]]

Filed bug 669462

Sort by users is not available for search tools browse pages: https://addons.allizom.org/en-US/firefox/search-tools/social-people?sort=rating

We show weekly downloads for search tools.

Comment 31

[krupa raj[:krupa]]

Attachment: post-fix screenshot