Closed
Bug 589403
Opened 13 years ago
Closed 13 years ago
Disable warning for mailto and tel in fennec
Categories
(Firefox for Android Graveyard :: General, defect)
Firefox for Android Graveyard
General
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: jbos, Assigned: jbos)
References
Details
Attachments
(1 file, 1 obsolete file)
892 bytes,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
Do not show "open in external programm" when clicking on mailto link. If not it looks like a warning, which we do not want in a integrated system.
Assignee | ||
Comment 1•13 years ago
|
||
This disables the warning
Attachment #468016 -
Flags: review?(mark.finkle)
Comment 2•13 years ago
|
||
Let's consider doing this for all Fennec platforms (Android too).
Assignee | ||
Comment 3•13 years ago
|
||
Sounds great, So who's call is it than? The patch should be changed in seconds
Comment 4•13 years ago
|
||
Why only mailto: ? Shouldn't we also consider doing this for tel: ?
Updated•13 years ago
|
OS: MeeGo → All
Hardware: x86 → All
Summary: Disable warning for mailto in meego fennec → Disable warning for mailto and tel in fennec
Comment 5•13 years ago
|
||
Just CC'ing some folks how might be able to give us a sanity check. We intend to remove the warning displayed when Fennec attempts to open a mailto: or tel: link in an external application. The external applications do not just fire off the command without user interaction. The warning dialog is hurting the easy flow of using the browser on mobile devices.
Updated•13 years ago
|
OS: All → MeeGo
Hardware: All → x86
Comment 6•13 years ago
|
||
I agree with this change. We can revisit if there's a security impact, but I suspect that the email client won't send an email, and the telephone application won't automatically dial :)
Updated•13 years ago
|
OS: MeeGo → All
Hardware: x86 → All
Comment 7•13 years ago
|
||
Comment on attachment 468016 [details] [diff] [review] disable preference * add tel: * not maemo specific, applies to all platforms
Attachment #468016 -
Flags: review?(mark.finkle) → review-
Assignee | ||
Comment 8•13 years ago
|
||
Ok Done.
Attachment #468016 -
Attachment is obsolete: true
Attachment #468840 -
Flags: review?(mark.finkle)
Updated•13 years ago
|
Attachment #468840 -
Flags: review?(mark.finkle) → review+
Comment 9•13 years ago
|
||
pushed: http://hg.mozilla.org/mobile-browser/rev/efcd1f5cd192
Assignee: nobody → jeremias.bosch
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Comment 10•13 years ago
|
||
Did this patch cause https://bugzilla.mozilla.org/show_bug.cgi?id=590477 ?
Comment 11•13 years ago
|
||
Nope
Comment 12•13 years ago
|
||
verified FIXED on build: Mozilla/5.0 (X11; U; Linux armv71; Nokia N900; en-US; rv:2.0b5pre) Gecko/20100826 Namoroka/4.0b5pre Fennec/2.0a1pre
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•